@@ -652,6 +652,7 @@ class StatsController < ApplicationController "AND tags.id = taggings.tag_id " + "AND taggings.taggable_id = todos.id ", current_user.id]) tags_ids_s = tag_ids.map(&:id).sort.join(",") + return {} if tags_ids_s.blank? # return empty array for .size to work return Tag.find(:all, :conditions => "id in (" + tags_ids_s + ")") end app/controllers/stats_controller.rb @@ -90,5 +90,21 @@ class StatsControllerTest < Test::Unit::TestCase assert_response :success assert_template "stats/show_selection_from_chart" end - + + def test_stats_render_when_tasks_have_no_taggings + login_as(:admin_user) + + # using the default fixtures, todos have tags + get :index + assert_response :success + + # clear taggings table and render again + taggings = Tagging.find(:all) + taggings.each do |t| + t.delete + end + get :index + assert_response :success + + end end test/functional/stats_controller_test.rb 278c7310c18cf245dca4291cce3168abc78ff9aa Reinier Balt lrbalt@gmail.com http://github.com/bsag/tracks/commit/8cdae83014eadccd194d1d907b14026ae4b418cd 8cdae83014eadccd194d1d907b14026ae4b418cd 2009-01-15T13:13:22-08:00 2009-01-15T13:13:22-08:00 fix case when there are no tags places on todos, the stats page would fail. Fixes #822. Thanks Walter for finding this one 15ba1a9d44a0aedd3889a6eb60b747e7f3d14ae2 Reinier Balt lrbalt@gmail.com