public
Description: Tracks is a GTD(TM) web application, built with Ruby on Rails
Homepage: http://www.rousette.org.uk/projects/
Clone URL: git://github.com/bsag/tracks.git
Click here to lend your support to: tracks and make a donation at www.pledgie.com !
Optimalized mobile pages - span for empty tags is not included, divs around tr 
were against html specification and caused some mobiles render the page 
incorrectly.
Jakub A.Tesinsky (author)
Mon Dec 01 17:22:36 -0800 2008
commit  a0d23629531f37728a0da046d8edc20a5a6f2907
tree    a04855848a4d4efaa69f80d128882d76628a19fb
parent  229a1144413fcf5633730d75cbe61c9314138ab6
...
117
118
119
120
 
121
122
123
...
117
118
119
 
120
121
122
123
0
@@ -117,7 +117,7 @@ module TodosHelper
0
       "<span class=\"tag\">" + 
0
         link_to(t.name, {:action => "tag", :controller => "todos", :id => t.name+".m"}) + 
0
       "</span>"}.join('')
0
-    "<span class=\"tags\">#{tag_list}</span>"
0
+    if not tag_list.empty? then "<span class=\"tags\">#{tag_list}</span>" end
0
   end
0
   
0
   def deferred_due_date
...
6
7
8
9
 
10
11
12
13
14
15
 
...
6
7
8
 
9
10
11
12
13
 
14
15
0
@@ -6,9 +6,9 @@ if not @not_done.empty?
0
   # only show a context when there are actions in it
0
   -%>
0
 <h2><%=mobile_context.name%></h2>
0
-<table cellpadding="0" cellspacing="0" border="0">
0
+<table cellpadding="0" cellspacing="0" border="0" class="c">
0
 <%= render :partial => "todos/mobile_todo", 
0
            :collection => @not_done, 
0
            :locals => { :parent_container_type => "context" }-%>
0
 </table>
0
-<% end -%>
0
\ No newline at end of file
0
+<% end -%>
...
4
5
6
7
8
 
9
10
11
...
23
24
25
26
27
 
...
4
5
6
 
 
7
8
9
10
...
22
23
24
 
25
26
0
@@ -4,8 +4,7 @@ if mobile_todo.starred?
0
 else
0
   bullet = "<span class=r>&raquo;&nbsp;</span>"
0
 end -%>
0
-<div class="t" id="<%= dom_id(mobile_todo) %>">
0
-<tr valign="top"><td><%= bullet %></td><td><% 
0
+<tr class="t" id="<%= dom_id(mobile_todo) %>" valign="top"><td><%= bullet %></td><td><% 
0
     if mobile_todo.completed?  
0
 -%><span class="m_t_d">
0
 <%  else 
0
@@ -23,4 +22,4 @@ end -%>
0
        ")</span>" -%>
0
 <%  end -%>
0
  <%= tag_list_mobile -%>
0
-</span></td></tr></div>
0
\ No newline at end of file
0
+</span></td></tr>
...
60
61
62
63
64
65
66
67
68
69
...
125
126
127
128
129
 
 
 
 
 
...
60
61
62
 
 
 
 
63
64
65
...
121
122
123
 
124
125
126
127
128
129
0
@@ -60,10 +60,6 @@ h4.notice {
0
   color: #007E00;
0
 }
0
 
0
-div.t {
0
-    padding-left:5px;
0
-}
0
-
0
 span.tag {
0
   font-size: XX-small;
0
   background-color: #CCE7FF;
0
@@ -125,4 +121,8 @@ span.prj, span.ctx{
0
 
0
 .errors {
0
       background: #FFC2C2;
0
-}
0
\ No newline at end of file
0
+}
0
+
0
+table.c {
0
+      margin-left: 5px;
0
+}

Comments