From 3a32acee96537f4500fb6bc2c6f51eebe5d8aa2f Mon Sep 17 00:00:00 2001 From: Pierre Tardy Date: Tue, 24 Feb 2015 19:01:07 +0100 Subject: [PATCH] address review comments --- master/buildbot/test/unit/test_changes_filter.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/master/buildbot/test/unit/test_changes_filter.py b/master/buildbot/test/unit/test_changes_filter.py index 03cbdb106d5..e391711bdb8 100644 --- a/master/buildbot/test/unit/test_changes_filter.py +++ b/master/buildbot/test/unit/test_changes_filter.py @@ -24,12 +24,6 @@ class Change(State): - def __init__(self, **kw): - State.__init__(self, **kw) - # change.properties is a IProperties - props = Properties() - props.update(self.properties, "test") - self.properties = props project = '' repository = '' branch = '' @@ -37,6 +31,13 @@ def __init__(self, **kw): codebase = '' properties = {} + def __init__(self, **kw): + State.__init__(self, **kw) + # change.properties is a IProperties + props = Properties() + props.update(self.properties, "test") + self.properties = props + class ChangeFilter(unittest.TestCase):