From 4b4dffc302781e7832c3e475538479fc0687792c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Alvarez?= Date: Thu, 23 Sep 2010 16:17:03 -0300 Subject: [PATCH] tgrid: Put default value of rev_order in a class variable. Avoids having the default value written twice (prone to mistakes if it changes), and allows easy monkey-patching of the default. --- master/buildbot/status/web/grid.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/master/buildbot/status/web/grid.py b/master/buildbot/status/web/grid.py index 2f78e257968..c20437776a1 100644 --- a/master/buildbot/status/web/grid.py +++ b/master/buildbot/status/web/grid.py @@ -181,6 +181,7 @@ class TransposedGridStatusResource(HtmlResource, GridStatusMixin): # TODO: docs status = None changemaster = None + default_rev_order = "asc" def content(self, request, cxt): """This method builds the transposed grid display. @@ -193,9 +194,9 @@ def content(self, request, cxt): branch = request.args.get("branch", [ANYBRANCH])[0] if branch == 'trunk': branch = None - rev_order = request.args.get("rev_order", ["asc"])[0] + rev_order = request.args.get("rev_order", [self.default_rev_order])[0] if rev_order not in ["asc", "desc"]: - rev_order = "asc" + rev_order = self.default_rev_order cxt['refresh'] = self.get_reload_time(request)