Merge pull request #3359 from uglycoyote/processIndexFix

Make gulp "processindex" command work under Windows
buildbot · Jun 23, 2017 · 6fb0d13 · 6fb0d13
2 parents 4cc3f70 + bc77657
commit 6fb0d13
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/master/buildbot/newsfragments/README.txt b/master/buildbot/newsfragments/README.txt
@@ -1,5 +1,7 @@
 This is the directory for news fragments used by towncrier: https://github.com/hawkowl/towncrier
 
+You create a news fragment in this directory when you make a change, and the file gets removed from this directory when the news is published.
+
 towncrier has a few standard types of news fragments, signified by the file extension. These are:
 
 .feature: Signifying a new feature.

diff --git a/master/buildbot/newsfragments/gulp_processindex_windows.bugfix b/master/buildbot/newsfragments/gulp_processindex_windows.bugfix
@@ -0,0 +1 @@
+     Fix Windows compatibility with frontend development tool ``gulp dev proxy`` (:issue:`3359`)
diff --git a/www/base/guanlecoja/config.coffee b/www/base/guanlecoja/config.coffee
@@ -59,7 +59,7 @@ config =
 gulp.task 'processindex', ['index'], ->
     indexpath = path.join(config.dir.build, 'index.html')
     gulp.src ""
-        .pipe shell("buildbot processwwwindex -i '#{indexpath}'")
+        .pipe shell("buildbot processwwwindex -i \"#{indexpath}\"")
 
 gulp.task 'proxy', ['processindex'], ->
     # this is a task for developing, it proxy api request to http://nine.buildbot.net