increment code coverage by testing the corner cases

buildbot · Jul 17, 2017 · eb32fac · eb32fac
1 parent c6741c5
commit eb32fac
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/master/buildbot/test/unit/test_data_builders.py b/master/buildbot/test/unit/test_data_builders.py
@@ -62,6 +62,14 @@ def check(builder):
             self.assertEqual(builder, None)
         return d
 
+    def test_get_missing_with_name(self):
+        d = self.callGet(('builders', 'builderc'))
+
+        @d.addCallback
+        def check(builder):
+            self.assertEqual(builder, None)
+        return d
+
     def test_get_existing_with_master(self):
         d = self.callGet(('masters', 13, 'builders', 2))
 

diff --git a/master/buildbot/test/unit/test_data_builds.py b/master/buildbot/test/unit/test_data_builds.py
@@ -95,6 +95,11 @@ def test_get_buildername_number(self):
         self.validateData(build)
         self.assertEqual(build['buildid'], 15)
 
+    @defer.inlineCallbacks
+    def test_get_buildername_not_existing_number(self):
+        build = yield self.callGet(('builders', 'builder77_nope', 'builds', 5))
+        self.assertEqual(build, None)
+
     @defer.inlineCallbacks
     def test_properties_injection(self):
         resultSpec = MockedResultSpec(

diff --git a/master/buildbot/test/unit/test_data_steps.py b/master/buildbot/test/unit/test_data_steps.py
@@ -106,6 +106,11 @@ def test_get_existing_builder_number(self):
         self.validateData(step)
         self.assertEqual(step['stepid'], 71)
 
+    @defer.inlineCallbacks
+    def test_get_missing_buildername_builder_number(self):
+        step = yield self.callGet(('builders', 'builder77_nope', 'builds', 7, 'steps', 1))
+        self.assertEqual(step, None)
+
     @defer.inlineCallbacks
     def test_get_missing(self):
         step = yield self.callGet(('steps', 9999))