From eb32facc919ad276dfd56070accaa2e353d00e4f Mon Sep 17 00:00:00 2001 From: Pierre Tardy Date: Mon, 17 Jul 2017 17:38:40 +0200 Subject: [PATCH] increment code coverage by testing the corner cases --- master/buildbot/test/unit/test_data_builders.py | 8 ++++++++ master/buildbot/test/unit/test_data_builds.py | 5 +++++ master/buildbot/test/unit/test_data_steps.py | 5 +++++ 3 files changed, 18 insertions(+) diff --git a/master/buildbot/test/unit/test_data_builders.py b/master/buildbot/test/unit/test_data_builders.py index c7243bd4c88..6af92516020 100644 --- a/master/buildbot/test/unit/test_data_builders.py +++ b/master/buildbot/test/unit/test_data_builders.py @@ -62,6 +62,14 @@ def check(builder): self.assertEqual(builder, None) return d + def test_get_missing_with_name(self): + d = self.callGet(('builders', 'builderc')) + + @d.addCallback + def check(builder): + self.assertEqual(builder, None) + return d + def test_get_existing_with_master(self): d = self.callGet(('masters', 13, 'builders', 2)) diff --git a/master/buildbot/test/unit/test_data_builds.py b/master/buildbot/test/unit/test_data_builds.py index 756f75af53e..0cc52fbbfbe 100644 --- a/master/buildbot/test/unit/test_data_builds.py +++ b/master/buildbot/test/unit/test_data_builds.py @@ -95,6 +95,11 @@ def test_get_buildername_number(self): self.validateData(build) self.assertEqual(build['buildid'], 15) + @defer.inlineCallbacks + def test_get_buildername_not_existing_number(self): + build = yield self.callGet(('builders', 'builder77_nope', 'builds', 5)) + self.assertEqual(build, None) + @defer.inlineCallbacks def test_properties_injection(self): resultSpec = MockedResultSpec( diff --git a/master/buildbot/test/unit/test_data_steps.py b/master/buildbot/test/unit/test_data_steps.py index 5999e862d5e..a52a55cd1ad 100644 --- a/master/buildbot/test/unit/test_data_steps.py +++ b/master/buildbot/test/unit/test_data_steps.py @@ -106,6 +106,11 @@ def test_get_existing_builder_number(self): self.validateData(step) self.assertEqual(step['stepid'], 71) + @defer.inlineCallbacks + def test_get_missing_buildername_builder_number(self): + step = yield self.callGet(('builders', 'builder77_nope', 'builds', 7, 'steps', 1)) + self.assertEqual(step, None) + @defer.inlineCallbacks def test_get_missing(self): step = yield self.callGet(('steps', 9999))