From ff1eef77c58ad35b42a5c0ba1f69e7c7f6516067 Mon Sep 17 00:00:00 2001 From: "Dustin J. Mitchell" Date: Sun, 14 Dec 2014 14:29:40 -0500 Subject: [PATCH] add comment for serializing remoteCommand --- master/buildbot/process/remotecommand.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/master/buildbot/process/remotecommand.py b/master/buildbot/process/remotecommand.py index 6a6ecadf295..04bb2cf279a 100644 --- a/master/buildbot/process/remotecommand.py +++ b/master/buildbot/process/remotecommand.py @@ -64,6 +64,9 @@ def __init__(self, remote_command, args, ignore_updates=False, self.builder_name = None self.commandID = None self.deferred = None + # a lock to make sure that only one log-handling method runs at a time. + # This is really only a problem with old-style steps, which do not + # wait for the Deferred from one method before invoking the next. self.loglock = defer.DeferredLock() def __repr__(self):