@@ -69,11 +69,13 @@ module NestedAssignment # deep saving of any new, changed, or deleted records. def create_or_update_with_associated(*args) + without_recursion(:create_or_update){ self.class.transaction do create_or_update_without_associated(*args) && - without_recursion(:create_or_update){modified_associated.all?{|a| a.save(*args)}} && + modified_associated.all?{|a| a.save(*args)} && deletable_associated.all?{|a| a.destroy} end + } end # Without this, we may not save deeply nested and changed records. lib/nested_assignment.rb @@ -52,4 +52,8 @@ module PluginTestModels validates_presence_of :name end + + class Event < ActiveRecord::Base + belongs_to :entity, :polymorphic => true + end end test/db/models.rb @@ -34,4 +34,9 @@ ActiveRecord::Schema.define(:version => 1) do t.column :user_id, :integer end + create_table :events, :force => true do |t| + t.column :entity_id, :integer + t.column :entity_type, :string + t.column :name, :string + end end test/db/schema.rb @@ -37,28 +37,41 @@ class NestedAssignmentSavingTest < ActiveSupport::TestCase assert_equal "difficult", @user.reload.tasks[0].tags[0].name end - def test_saving_with_recursive_references - # This recursive situation is a little contrived. A more likely example would be - # a new associated record that refers back to the first. For example, suppose you - # store events, and after the user modifies his name you wish to store the fact. - # You may do something like `Event.create(:user => self, :change => 'name')`. This - # would create a recursive reference such as here. + def test_saving! @user = users(:bob) - @user.name = "william" @user.tasks[0].name = "research" - @user.tasks[0].user = @user - assert_nothing_raised do - @user.save + @user.save! + assert_equal "research", @user.reload.tasks[0].name + end + + class UserWithEvent < User + after_save do |user| + PluginTestModels::Event.create(:entity => user) + end + end + + def test_saving_a_modified_record_that_spawns_an_associated_record + @user = UserWithEvent.find(:first) + @user.name = "william" + assert_difference "Event.count", 1 do + assert_nothing_raised do + @user.save + end end @user.reload assert_equal "william", @user.name - assert_equal "research", @user.tasks[0].name end - def test_saving! - @user = users(:bob) - @user.tasks[0].name = "research" - @user.save! - assert_equal "research", @user.reload.tasks[0].name + class UserWithResave < User + after_create do |user| + user.update_attribute(:name, "#{user.name} (verified)") + end + end + + def test_saving_a_new_record_with_a_single_resave + @user = UserWithResave.new + @user.name = "george" + @user.save + assert_equal "george (verified)", @user.reload.name end end test/unit/nested_assignment_saving_test.rb ed595a7da8f40a894eab7cb542ab0c0b60f0c759 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/5828485d657c1a8f468f4ea64f3ba273fff532b0 5828485d657c1a8f468f4ea64f3ba273fff532b0 2008-12-17T20:17:16-08:00 2008-12-17T20:17:16-08:00 writing test coverage for two conflicting saving patterns this plugin needs to support. c258e98ae239821714c04e38a0e4765d3b612bd5 Lance Ivy lance@cainlevy.net