5828485d657c1a8f468f4ea64f3ba273fff532b0 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/8ca1d4a81f0c9481c953a2d77179aeb215eb4870 8ca1d4a81f0c9481c953a2d77179aeb215eb4870 2009-01-07T18:58:04-08:00 2009-01-07T18:57:24-08:00 keep the recursion stack clean even if there's an exception (credit: Ian Smith-Heisters) 00243ac112b890fc6e52999afba1a9318c6e3cd5 Lance Ivy lance@cainlevy.net ed595a7da8f40a894eab7cb542ab0c0b60f0c759 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/5828485d657c1a8f468f4ea64f3ba273fff532b0 5828485d657c1a8f468f4ea64f3ba273fff532b0 2008-12-17T20:17:16-08:00 2008-12-17T20:17:16-08:00 writing test coverage for two conflicting saving patterns this plugin needs to support. c258e98ae239821714c04e38a0e4765d3b612bd5 Lance Ivy lance@cainlevy.net 408f47d446f6946e1938331b7665fe10dbd8c0cd Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/ed595a7da8f40a894eab7cb542ab0c0b60f0c759 ed595a7da8f40a894eab7cb542ab0c0b60f0c759 2008-12-16T17:43:19-08:00 2008-12-16T17:43:19-08:00 pass arguments to all child saves, not just the chained save a9487615fa522f215714c0e1d98cc2bf6c075046 Lance Ivy lance@cainlevy.net f09fc314119b5cd6fdca8ee3c32b4ede9eddb571 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/408f47d446f6946e1938331b7665fe10dbd8c0cd 408f47d446f6946e1938331b7665fe10dbd8c0cd 2008-12-13T19:23:07-08:00 2008-12-13T19:23:07-08:00 chain on create_or_update instead of save, to also work with save! ec081bc69dffc50a97e20d71896055e91d7020bb Lance Ivy lance@cainlevy.net 5012f410069ee5c68847f02c8c9954138955723c Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/f09fc314119b5cd6fdca8ee3c32b4ede9eddb571 f09fc314119b5cd6fdca8ee3c32b4ede9eddb571 2008-12-13T18:26:16-08:00 2008-12-13T18:26:16-08:00 more limited application of recursion control for saves, to allow "subsaves" (e.g. updating again in an after_save callback) 050ed5739be3ed38d47dec7cb8da19101b553e13 Lance Ivy lance@cainlevy.net cfba211138191b0e58eaf90af7637dd5de4a8714 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/5012f410069ee5c68847f02c8c9954138955723c 5012f410069ee5c68847f02c8c9954138955723c 2008-12-13T17:35:50-08:00 2008-12-13T17:35:50-08:00 backing off on automatically validating/saving deeply nested modified records. the penalty is too big. see the newly failing tests for the tradeoff. 93d1f89529b54c97a477a0a0c7bde6392d7647b8 Lance Ivy lance@cainlevy.net 64d8249daa8f2f66b367292b3308c36da24c30c0 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/cfba211138191b0e58eaf90af7637dd5de4a8714 cfba211138191b0e58eaf90af7637dd5de4a8714 2008-12-13T17:17:12-08:00 2008-12-13T17:17:12-08:00 adding recursion control to valid?(), save(), and changed?() 3de499ea758233b45573310c8babe5c15353546d Lance Ivy lance@cainlevy.net dcc76e33738e245a214fbc19a0d351e031f0017e Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/64d8249daa8f2f66b367292b3308c36da24c30c0 64d8249daa8f2f66b367292b3308c36da24c30c0 2008-12-13T16:16:09-08:00 2008-12-13T16:16:09-08:00 performance tweaks: avoiding Symbol#to_proc, and trying not to duplicate ActiveRecord's own validation and saving of new associated records 05661858b4b7c0eb50136f032bc68143f68243c5 Lance Ivy lance@cainlevy.net 41f7a39d87bb6525b63c79ec1212a61310b13724 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/dcc76e33738e245a214fbc19a0d351e031f0017e dcc76e33738e245a214fbc19a0d351e031f0017e 2008-12-13T01:59:25-08:00 2008-12-13T01:59:25-08:00 completely ignore new records that have :_delete => 1 d4cbca8ecb5faf4625bb91cf422191b7ef352925 Lance Ivy lance@cainlevy.net 1d2d8dc259c9c5aca6d8379466b748943b0729c4 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/41f7a39d87bb6525b63c79ec1212a61310b13724 41f7a39d87bb6525b63c79ec1212a61310b13724 2008-12-12T14:48:46-08:00 2008-12-12T14:48:46-08:00 rdoc afd0daf61fca296f9febe7516d5f50403821f6ec Lance Ivy lance@cainlevy.net 657810daec470de139d3ae1b3cd67da7a20bdf0b Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/1d2d8dc259c9c5aca6d8379466b748943b0729c4 1d2d8dc259c9c5aca6d8379466b748943b0729c4 2008-12-12T14:44:00-08:00 2008-12-12T14:44:00-08:00 this is rdoc, right? c110344546faab190de8ddbfb61ef366349576e5 Lance Ivy lance@cainlevy.net c4ff9106c91440cde13a603ebda81b7ddc321b19 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/657810daec470de139d3ae1b3cd67da7a20bdf0b 657810daec470de139d3ae1b3cd67da7a20bdf0b 2008-12-12T14:39:13-08:00 2008-12-12T14:39:13-08:00 tests for save_with_associated 59c54b9efe57d4ff30c578a508690e566b73b087 Lance Ivy lance@cainlevy.net b74ee49c0a998b7ec1143dfd96ae76ec41931295 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/c4ff9106c91440cde13a603ebda81b7ddc321b19 c4ff9106c91440cde13a603ebda81b7ddc321b19 2008-12-12T14:38:52-08:00 2008-12-12T14:38:30-08:00 ignore the test log 149c757e12efeca3303f09970d8424c54750bf28 Lance Ivy lance@cainlevy.net 1585173445129078f0a502fd07e016a6758e234d Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/b74ee49c0a998b7ec1143dfd96ae76ec41931295 b74ee49c0a998b7ec1143dfd96ae76ec41931295 2008-12-12T14:31:05-08:00 2008-12-12T14:31:05-08:00 testing valid_with_associated? e0e570b5fdd99b8c4f37825b68414120e43bd65b Lance Ivy lance@cainlevy.net 5f3b15f22d4401399b366a14b41aca831eaf5bfd Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/1585173445129078f0a502fd07e016a6758e234d 1585173445129078f0a502fd07e016a6758e234d 2008-12-12T14:10:18-08:00 2008-12-12T14:10:18-08:00 linking the broken test to a rubyonrails-core thread 62c7ba89b0050879d5b8dff0c343c7d4b338fde0 Lance Ivy lance@cainlevy.net 92b948318da59fe140bf0afc8031546baf4e0484 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/5f3b15f22d4401399b366a14b41aca831eaf5bfd 5f3b15f22d4401399b366a14b41aca831eaf5bfd 2008-12-12T14:06:28-08:00 2008-12-12T14:06:28-08:00 simplifying the parameter format for singular associations 626aca90913c140dcc8e0b92ba7a47465eafb8bd Lance Ivy lance@cainlevy.net 0e161b087f6f58b9e2b0389f95d683d523e647e0 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/92b948318da59fe140bf0afc8031546baf4e0484 92b948318da59fe140bf0afc8031546baf4e0484 2008-12-12T14:00:42-08:00 2008-12-12T14:00:42-08:00 moving to a more plausible (?) model/fixture setup 3485471122f331f02694e44517104f43750b7495 Lance Ivy lance@cainlevy.net 69908c4e0a12c3da4c45a8a27db32dc392b3e534 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/0e161b087f6f58b9e2b0389f95d683d523e647e0 0e161b087f6f58b9e2b0389f95d683d523e647e0 2008-12-12T13:08:19-08:00 2008-12-12T13:08:19-08:00 fleshing out assignment tests for all association types db68a06c65390e6f6f024a2666c58e193f990790 Lance Ivy lance@cainlevy.net d06a4b0936dd04aed64f6d93374f10a44924d960 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/69908c4e0a12c3da4c45a8a27db32dc392b3e534 69908c4e0a12c3da4c45a8a27db32dc392b3e534 2008-12-11T18:04:56-08:00 2008-12-11T18:04:56-08:00 some progress on has_one association testing. ran into wall trying to replace an existing singular association. 1db86222cce7fd97bb55ec408db870edfbbd007b Lance Ivy lance@cainlevy.net e5d7bb41446f3beb1266e1ed6d0589117e7c0ec2 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/d06a4b0936dd04aed64f6d93374f10a44924d960 d06a4b0936dd04aed64f6d93374f10a44924d960 2008-12-11T15:32:48-08:00 2008-12-11T15:32:48-08:00 getting my testing on -- starting with the small helper methods e358f121c34d1eeb68d3121b049e8c0d0c728382 Lance Ivy lance@cainlevy.net e1a484f31c7f8d50ee66ccdb9f2b6ed6b3add0e1 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/e5d7bb41446f3beb1266e1ed6d0589117e7c0ec2 e5d7bb41446f3beb1266e1ed6d0589117e7c0ec2 2008-12-11T14:43:43-08:00 2008-12-11T14:43:43-08:00 importing and adapting my database-driven test setup f90bdc8ee8463e636b6fd534e3c5013a7f8907be Lance Ivy lance@cainlevy.net ee800593c3b91aaf50abe34cda36224d4501dde4 Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/e1a484f31c7f8d50ee66ccdb9f2b6ed6b3add0e1 e1a484f31c7f8d50ee66ccdb9f2b6ed6b3add0e1 2008-12-11T14:33:32-08:00 2008-12-11T14:33:32-08:00 importing untested concept code 1e52e94f65b65aea987fe0d8d2c9267a3ec3e8ba Lance Ivy lance@cainlevy.net Lance Ivy lance@cainlevy.net http://github.com/cainlevy/nested_assignment/commit/ee800593c3b91aaf50abe34cda36224d4501dde4 ee800593c3b91aaf50abe34cda36224d4501dde4 2008-12-11T14:19:52-08:00 2008-12-11T14:19:52-08:00 jotting down thoughts f9d871e8395278bc47b5e14ad3178bcda4599671 Lance Ivy lance@cainlevy.net