changed HtmlHelper::tag() just return $text when empty($name)

cakephp · May 20, 2013 · 0d082b5 · 0d082b5
1 parent 12462b2
commit 0d082b5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/Cake/Test/Case/View/Helper/HtmlHelperTest.php b/lib/Cake/Test/Case/View/Helper/HtmlHelperTest.php
@@ -1697,6 +1697,12 @@ public function testTag() {
 
 		$result = $this->Html->tag(false, '<em>stuff</em>');
 		$this->assertEquals($result, '<em>stuff</em>');
+
+		$result = $this->Html->tag(null, '<em>stuff</em>');
+		$this->assertEquals($result, '<em>stuff</em>');
+
+		$result = $this->Html->tag('', '<em>stuff</em>');
+		$this->assertEquals($result, '<em>stuff</em>');
 	}
 
 /**

diff --git a/lib/Cake/View/Helper/HtmlHelper.php b/lib/Cake/View/Helper/HtmlHelper.php
@@ -896,7 +896,7 @@ public function tableCells($data, $oddTrOptions = null, $evenTrOptions = null, $
  * @link http://book.cakephp.org/2.0/en/core-libraries/helpers/html.html#HtmlHelper::tag
  */
 	public function tag($name, $text = null, $options = array()) {
-		if ($name === false) {
+		if (empty($name)) {
 			return $text;
 		}
 		if (is_array($options) && isset($options['escape']) && $options['escape']) {