From 100e1a4749b731be5802035e7e7aa1c655a297c2 Mon Sep 17 00:00:00 2001 From: Jose Lorenzo Rodriguez Date: Fri, 26 Sep 2014 20:59:03 +0200 Subject: [PATCH] Removing magic left join elimation for subquery strategy. This was extremely error prone as some in the core team figured out, and was only solving a cosmetic issue. --- src/ORM/Association/SelectableAssociationTrait.php | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/ORM/Association/SelectableAssociationTrait.php b/src/ORM/Association/SelectableAssociationTrait.php index 1f30efdc381..42d4599d253 100644 --- a/src/ORM/Association/SelectableAssociationTrait.php +++ b/src/ORM/Association/SelectableAssociationTrait.php @@ -224,20 +224,12 @@ protected function _buildSubquery($query) { $filterQuery->offset(null); } - $joins = $filterQuery->join(); - foreach ($joins as $i => $join) { - if (strtolower($join['type']) !== 'inner') { - unset($joins[$i]); - } - } - $keys = (array)$query->repository()->primaryKey(); if ($this->type() === $this::MANY_TO_ONE) { $keys = (array)$this->foreignKey(); } - $filterQuery->join($joins, [], true); $fields = $query->aliasFields($keys); return $filterQuery->select($fields, true); }