Do not change session handler if session is active

Avoid notice "session_set_save_handler(): Cannot change save handler when session is active" on PHP 7.2
cakephp · Oct 13, 2018 · 201b28b · 201b28b
1 parent cb3034e
commit 201b28b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Http/Session.php b/src/Http/Session.php
@@ -290,7 +290,7 @@ public function engine($class = null, array $options = [])
      */
     protected function setEngine(SessionHandlerInterface $handler)
     {
-        if (!headers_sent()) {
+        if (!headers_sent() && session_status() !== \PHP_SESSION_ACTIVE) {
             session_set_save_handler($handler, false);
         }
 
@@ -535,7 +535,7 @@ public function destroy()
             $this->start();
         }
 
-        if (!$this->_isCLI && session_status() === PHP_SESSION_ACTIVE) {
+        if (!$this->_isCLI && session_status() === \PHP_SESSION_ACTIVE) {
             session_destroy();
         }