Improving error message when the funciton is no callable in the provider

cakephp · Nov 20, 2013 · 21129a8 · 21129a8
1 parent 27728be
commit 21129a8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/Cake/Test/TestCase/Validation/ValidationRuleTest.php b/Cake/Test/TestCase/Validation/ValidationRuleTest.php
@@ -80,7 +80,7 @@ public function testCustomMethods() {
  * Make sure errors are triggered when validation is missing.
  *
  * @expectedException \InvalidArgumentException
- * @expectedExceptionMessage Invalid validation callable
+ * @expectedExceptionMessage Unable to call method totallyMissing in default provider
  * @return void
  */
 	public function testCustomMethodMissingError() {

diff --git a/Cake/Validation/ValidationRule.php b/Cake/Validation/ValidationRule.php
@@ -117,7 +117,10 @@ public function process($data, $providers, $newRecord) {
 		}
 
 		if (!$isCallable) {
-			throw new \InvalidArgumentException('Invalid validation callable');
+			$message = 'Unable to call method %s in %s provider';
+			throw new \InvalidArgumentException(
+				sprintf($message, $this->_rule, $this->_provider)
+			);
 		}
 
 		if ($this->_pass) {