Skip to content

Commit

Permalink
fix broken tests for TestTask class
Browse files Browse the repository at this point in the history
  • Loading branch information
huoxito committed May 11, 2012
1 parent c651bf2 commit 287c7b4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 12 deletions.
4 changes: 2 additions & 2 deletions lib/Cake/Console/Templates/default/classes/test.ctp
Expand Up @@ -28,9 +28,9 @@ App::uses('<?php echo $dependency[0]; ?>', '<?php echo $dependency[1]; ?>');
*
*/
<?php if ($type === 'Controller'): ?>
class <?php echo $fullClassName; ?>TestCase extends ControllerTestCase {
class <?php echo $fullClassName; ?>Test extends ControllerTestCase {
<?php else: ?>
class <?php echo $fullClassName; ?>TestCase extends CakeTestCase {
class <?php echo $fullClassName; ?>Test extends CakeTestCase {
<?php endif; ?>

<?php if (!empty($fixtures)): ?>
Expand Down
14 changes: 4 additions & 10 deletions lib/Cake/Test/Case/Console/Command/Task/TestTaskTest.php
Expand Up @@ -455,9 +455,7 @@ public function testBakeModelTest() {
}

/**
* test baking controller test files, ensure that the stub class is generated.
* Conditional assertion is known to fail on PHP4 as classnames are all lower case
* causing issues with inflection of path name from classname.
* test baking controller test files
*
* @return void
*/
Expand All @@ -468,14 +466,10 @@ public function testBakeControllerTest() {
$result = $this->Task->bake('Controller', 'TestTaskComments');

$this->assertContains("App::uses('TestTaskCommentsController', 'Controller')", $result);
$this->assertContains('class TestTaskCommentsControllerTest extends CakeTestCase', $result);

$this->assertContains('class TestTestTaskCommentsController extends TestTaskCommentsController', $result);
$this->assertContains('public $autoRender = false', $result);
$this->assertContains('function redirect($url, $status = null, $exit = true)', $result);
$this->assertContains('class TestTaskCommentsControllerTest extends ControllerTestCase', $result);

$this->assertContains('function setUp()', $result);
$this->assertContains("\$this->TestTaskComments = new TestTestTaskCommentsController()", $result);
$this->assertContains("\$this->TestTaskComments = new TestTaskCommentsController()", $result);
$this->assertContains("\$this->TestTaskComments->constructClasses()", $result);

$this->assertContains('function tearDown()', $result);
Expand Down Expand Up @@ -556,7 +550,7 @@ public function testBakeHelperTest() {
*/
public function testGenerateConstructor() {
$result = $this->Task->generateConstructor('controller', 'PostsController', null);
$expected = array('', "new TestPostsController();\n", "\$this->Posts->constructClasses();\n");
$expected = array('', "new PostsController();\n", "\$this->Posts->constructClasses();\n");
$this->assertEquals($expected, $result);

$result = $this->Task->generateConstructor('model', 'Post', null);
Expand Down

0 comments on commit 287c7b4

Please sign in to comment.