diff --git a/src/Error/ExceptionRenderer.php b/src/Error/ExceptionRenderer.php index cac8cfecc8e..6352a9203aa 100644 --- a/src/Error/ExceptionRenderer.php +++ b/src/Error/ExceptionRenderer.php @@ -200,8 +200,8 @@ public function render() if ($unwrapped instanceof CakeException && $isDebug) { $this->controller->set($unwrapped->getAttributes()); } - $this->controller->response = $response; + return $this->_outputMessage($template); } diff --git a/src/Routing/Filter/AssetFilter.php b/src/Routing/Filter/AssetFilter.php index 3ef0108653b..1c925777ec5 100644 --- a/src/Routing/Filter/AssetFilter.php +++ b/src/Routing/Filter/AssetFilter.php @@ -131,7 +131,7 @@ protected function _getAssetFile($url) protected function _deliverAsset(ServerRequest $request, Response $response, $assetFile, $ext) { $compressionEnabled = $response->compress(); - if ($response->getType($ext) === $ext) { + if ($response->getType() === $ext) { $contentType = 'application/octet-stream'; $agent = $request->getEnv('HTTP_USER_AGENT'); if (preg_match('%Opera(/| )([0-9].[0-9]{1,2})%', $agent) || preg_match('/MSIE ([0-9].[0-9]{1,2})/', $agent)) { diff --git a/tests/TestCase/View/ViewBuilderTest.php b/tests/TestCase/View/ViewBuilderTest.php index 987f547e760..f9f79b0b706 100644 --- a/tests/TestCase/View/ViewBuilderTest.php +++ b/tests/TestCase/View/ViewBuilderTest.php @@ -14,6 +14,8 @@ */ namespace Cake\Test\TestCase\View; +use Cake\Http\Response; +use Cake\Http\ServerRequest; use Cake\TestSuite\TestCase; use Cake\View\ViewBuilder; @@ -108,8 +110,8 @@ public function testArrayPropertyMerge($property, $value) */ public function testBuildComplete() { - $request = $this->getMockBuilder('Cake\Http\ServerRequest')->getMock(); - $response = $this->getMockBuilder('Cake\Http\Response')->getMock(); + $request = new ServerRequest(); + $response = new Response(); $events = $this->getMockBuilder('Cake\Event\EventManager')->getMock(); $builder = new ViewBuilder(); @@ -136,7 +138,7 @@ public function testBuildComplete() $this->assertEquals('TestPlugin', $view->plugin); $this->assertEquals('TestTheme', $view->theme); $this->assertSame($request, $view->request); - $this->assertSame($response, $view->response); + $this->assertInstanceOf(Response::class, $view->response); $this->assertSame($events, $view->getEventManager()); $this->assertSame(['one' => 'value'], $view->viewVars); $this->assertInstanceOf('Cake\View\Helper\HtmlHelper', $view->Html);