Updating SessionComponent::setFlash

cakephp · May 18, 2014 · 346c341 · 346c341
1 parent 4c3f85b
commit 346c341
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/src/Controller/Component/SessionComponent.php b/src/Controller/Component/SessionComponent.php
@@ -122,7 +122,7 @@ public function check($name) {
  * @link http://book.cakephp.org/2.0/en/core-libraries/components/sessions.html#creating-notification-messages
  */
 	public function setFlash($message, $element = 'default', array $params = array(), $key = 'flash') {
-		$this->write('Message.' . $key, compact('message', 'element', 'params'));
+		$this->_session->flash($message, 'info', $params + compact('element', 'key'));
 	}
 
 /**

diff --git a/tests/TestCase/Controller/Component/SessionComponentTest.php b/tests/TestCase/Controller/Component/SessionComponentTest.php
@@ -171,18 +171,11 @@ public function testSessionFlash() {
 		$this->assertNull($Session->read('Message.flash'));
 
 		$Session->setFlash('This is a test message');
-		$this->assertEquals(array('message' => 'This is a test message', 'element' => 'default', 'params' => array()), $Session->read('Message.flash'));
-
-		$Session->setFlash('This is a test message', 'test', array('name' => 'Joel Moss'));
-		$this->assertEquals(array('message' => 'This is a test message', 'element' => 'test', 'params' => array('name' => 'Joel Moss')), $Session->read('Message.flash'));
-
-		$Session->setFlash('This is a test message', 'default', array(), 'myFlash');
-		$this->assertEquals(array('message' => 'This is a test message', 'element' => 'default', 'params' => array()), $Session->read('Message.myFlash'));
-
-		$Session->setFlash('This is a test message', 'non_existing_layout');
-		$this->assertEquals(array('message' => 'This is a test message', 'element' => 'default', 'params' => array()), $Session->read('Message.myFlash'));
-
-		$Session->delete('Message');
+		$this->assertEquals(array(
+				'message' => 'This is a test message',
+				'params' => array('element' => 'default'),
+				'type' => 'info'
+			), $Session->read('Message.flash'));
 	}
 
 /**