From 39f2b8a9ece5c4eae24cf8bb6ec54488d244002a Mon Sep 17 00:00:00 2001 From: Jeremy Harris Date: Sat, 24 Jun 2017 18:08:18 -0500 Subject: [PATCH] Loading PHPUnit aliases once from all initial autoloaded files --- src/TestSuite/Fixture/FixtureInjector.php | 7 +------ src/TestSuite/Fixture/FixtureManager.php | 2 ++ src/TestSuite/TestSuite.php | 8 +------- src/basics.php | 15 +++++++++++++++ tests/phpunit_aliases.php | 10 ++++++++++ 5 files changed, 29 insertions(+), 13 deletions(-) create mode 100644 tests/phpunit_aliases.php diff --git a/src/TestSuite/Fixture/FixtureInjector.php b/src/TestSuite/Fixture/FixtureInjector.php index 7f9c1e28644..74edb48a30e 100644 --- a/src/TestSuite/Fixture/FixtureInjector.php +++ b/src/TestSuite/Fixture/FixtureInjector.php @@ -14,12 +14,7 @@ */ namespace Cake\TestSuite\Fixture; -if (class_exists('PHPUnit_Runner_Version')) { - if (version_compare(\PHPUnit_Runner_Version::id(), '5.7', '<')) { - trigger_error(sprintf('Your PHPUnit Version must be at least 5.7.0 to use CakePHP Testsuite, found %s', \PHPUnit_Runner_Version::id()), E_USER_ERROR); - } - class_alias('PHPUnit_Framework_Test', 'PHPUnit\Framework\Test'); -} +loadPHPUnitAliases(); use Cake\TestSuite\TestCase; use PHPUnit\Framework\BaseTestListener; diff --git a/src/TestSuite/Fixture/FixtureManager.php b/src/TestSuite/Fixture/FixtureManager.php index d083cef65ff..88a7a633bfc 100644 --- a/src/TestSuite/Fixture/FixtureManager.php +++ b/src/TestSuite/Fixture/FixtureManager.php @@ -14,6 +14,8 @@ */ namespace Cake\TestSuite\Fixture; +loadPHPUnitAliases(); + use Cake\Core\Configure; use Cake\Core\Exception\Exception; use Cake\Database\Schema\TableSchema; diff --git a/src/TestSuite/TestSuite.php b/src/TestSuite/TestSuite.php index 1438abdb532..1c27a5bb2c2 100644 --- a/src/TestSuite/TestSuite.php +++ b/src/TestSuite/TestSuite.php @@ -16,13 +16,7 @@ */ namespace Cake\TestSuite; -if (class_exists('PHPUnit_Runner_Version')) { - if (version_compare(\PHPUnit_Runner_Version::id(), '5.7', '<')) { - trigger_error(sprintf('Your PHPUnit Version must be at least 5.7.0 to use CakePHP Testsuite, found %s', \PHPUnit_Runner_Version::id()), E_USER_ERROR); - } - class_alias('PHPUnit_Framework_TestSuite', 'PHPUnit\Framework\TestSuite'); - class_alias('PHPUnit_Framework_AssertionFailedError', 'PHPUnit\Framework\AssertionFailedError'); -} +loadPHPUnitAliases(); use Cake\Filesystem\Folder; use PHPUnit\Framework\TestSuite as BaseTestSuite; diff --git a/src/basics.php b/src/basics.php index 546c791ea6d..6c1dd004d65 100644 --- a/src/basics.php +++ b/src/basics.php @@ -140,3 +140,18 @@ function dd($var, $showHtml = null) die(1); } } + +if (!function_exists('loadPHPUnitAliases')) { + /** + * Loads PHPUnit aliases + * + * This is an internal function used for backwards compatibility during + * fixture related tests. + * + * @return void + */ + function loadPHPUnitAliases() + { + require_once dirname(__DIR__) . DS . 'tests' . DS . 'phpunit_aliases.php'; + } +} diff --git a/tests/phpunit_aliases.php b/tests/phpunit_aliases.php new file mode 100644 index 00000000000..af47da95df7 --- /dev/null +++ b/tests/phpunit_aliases.php @@ -0,0 +1,10 @@ +