diff --git a/lib/Cake/Test/Case/Utility/XmlTest.php b/lib/Cake/Test/Case/Utility/XmlTest.php index cd1fc87b45b..4141dfe4ee0 100644 --- a/lib/Cake/Test/Case/Utility/XmlTest.php +++ b/lib/Cake/Test/Case/Utility/XmlTest.php @@ -1035,4 +1035,22 @@ public function testAmpInText() { $this->assertContains('mark & mark', $result); } +/** + * Test that entity loading is disabled by default. + * + * @return void + */ + public function testNoEntityLoading() { + $file = CAKE . 'VERSION.txt'; + $xml = <<]> + + &payload; + +XML; + $result = Xml::build($xml); + $this->assertEquals('', (string)$result->xxe); + } + } diff --git a/lib/Cake/Utility/Xml.php b/lib/Cake/Utility/Xml.php index 1f9f69caf39..727b5925ab6 100644 --- a/lib/Cake/Utility/Xml.php +++ b/lib/Cake/Utility/Xml.php @@ -74,6 +74,8 @@ class Xml { * ### Options * * - `return` Can be 'simplexml' to return object of SimpleXMLElement or 'domdocument' to return DOMDocument. + * - `loadEntities` Defaults to false. Set to true to enable loading of ` (string)$options); } $defaults = array( - 'return' => 'simplexml' + 'return' => 'simplexml', + 'loadEntities' => false, ); $options = array_merge($defaults, $options); if (is_array($input) || is_object($input)) { return self::fromArray((array)$input, $options); } elseif (strpos($input, '<') !== false) { - if ($options['return'] === 'simplexml' || $options['return'] === 'simplexmlelement') { - return new SimpleXMLElement($input, LIBXML_NOCDATA); - } - $dom = new DOMDocument(); - $dom->loadXML($input); - return $dom; + return self::_loadXml($input, $options); } elseif (file_exists($input) || strpos($input, 'http://') === 0 || strpos($input, 'https://') === 0) { - if ($options['return'] === 'simplexml' || $options['return'] === 'simplexmlelement') { - return new SimpleXMLElement($input, LIBXML_NOCDATA, true); - } - $dom = new DOMDocument(); - $dom->load($input); - return $dom; + $input = file_get_contents($input); + return self::_loadXml($input, $options); } elseif (!is_string($input)) { throw new XmlException(__d('cake_dev', 'Invalid input.')); } throw new XmlException(__d('cake_dev', 'XML cannot be read.')); } +/** + * Parse the input data and create either a SimpleXmlElement object or a DOMDocument. + * + * @param string $input The input to load. + * @param array $options The options to use. See Xml::build() + * @return SimpleXmlElement|DOMDocument. + */ + protected static function _loadXml($input, $options) { + $hasDisable = function_exists('libxml_disable_entity_loader'); + $internalErrors = libxml_use_internal_errors(true); + if ($hasDisable && !$options['loadEntities']) { + libxml_disable_entity_loader(true); + } + if ($options['return'] === 'simplexml' || $options['return'] === 'simplexmlelement') { + $xml = new SimpleXMLElement($input, LIBXML_NOCDATA); + } else { + $xml = new DOMDocument(); + $xml->loadXML($input); + } + if ($hasDisable && !$options['loadEntities']) { + libxml_disable_entity_loader(false); + } + libxml_use_internal_errors($internalErrors); + return $xml; + } + /** * Transform an array into a SimpleXMLElement *