Add tests for CakeRoute::match() and trailing * routes.

Add tests for /pages/** routes, and fix coding standards errors. Refs #3581
cakephp · Jun 3, 2014 · 4362f7b · 4362f7b
1 parent c622a9d
commit 4362f7b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/lib/Cake/Routing/Route/CakeRoute.php b/lib/Cake/Routing/Route/CakeRoute.php
@@ -536,11 +536,10 @@ protected function _writeUrl($params) {
 			$out = str_replace($search, $replace, $out);
 		}
 
-		if (strpos($this->template, '**')) {
+		if (strpos($this->template, '**') !== false) {
 			$out = str_replace('**', $params['pass'], $out);
 			$out = str_replace('%2F', '/', $out);
-		} 
-		elseif (strpos($this->template, '*')) {
+		} elseif (strpos($this->template, '*') !== false) {
 			$out = str_replace('*', $params['pass'], $out);
 		}
 		$out = str_replace('//', '/', $out);

diff --git a/lib/Cake/Test/Case/Routing/Route/CakeRouteTest.php b/lib/Cake/Test/Case/Routing/Route/CakeRouteTest.php
@@ -873,6 +873,23 @@ public function testMatchSimilarParameters() {
 		$this->assertEquals($expected, $result);
 	}
 
+/**
+ * Test match() with trailing ** style routes.
+ *
+ * @return void
+ */
+	public function testMatchTrailing() {
+		$route = new CakeRoute('/pages/**', array('controller' => 'pages', 'action' => 'display'));
+		$id = 'test/ spaces/漢字/la†în';
+		$result = $route->match(array(
+			'controller' => 'pages',
+			'action' => 'display',
+			$id
+		));
+		$expected = '/pages/test/%20spaces/%E6%BC%A2%E5%AD%97/la%E2%80%A0%C3%AEn';
+		$this->assertEquals($expected, $result);
+	}
+
 /**
  * test restructuring args with pass key
  *