Fixed code for lastN when passing a countable

cakephp · Sep 4, 2018 · 479f87e · 479f87e
1 parent f2525fc
commit 479f87e
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 4 deletions.
diff --git a/src/Collection/CollectionTrait.php b/src/Collection/CollectionTrait.php
@@ -415,9 +415,11 @@ public function lastN($howMany)
 
         if ($iterator instanceof Countable) {
             $count = count($iterator);
+
             if ($count === 0) {
-                return null;
+                return new Collection([]);
             }
+
             $iterator = new LimitIterator($iterator, max(0, $count - $howMany), $howMany);
 
             return new Collection($iterator);

diff --git a/tests/TestCase/Collection/CollectionTest.php b/tests/TestCase/Collection/CollectionTest.php
@@ -63,6 +63,24 @@ public function checkValues()
     }
 }
 
+class CountableIterator extends \IteratorIterator implements \Countable
+{
+    public function __construct($items)
+    {
+        $f = function () use ($items) {
+            foreach ($items as $e) {
+                yield $e;
+            }
+        };
+        parent::__construct($f());
+    }
+
+    public function count()
+    {
+        return 6;
+    }
+}
+
 /**
  * CollectionTest
  */
@@ -2199,11 +2217,12 @@ public function testLasNtWithOddData($data)
      */
     public function testLasNtWithCountable()
     {
-        $collection = new Collection(new ArrayObject([1, 2, 3, 4, 5]));
-        $result = $collection->lastN(2)->toArray();
+        $collection = new Collection(new CountableIterator(range(0, 5)));
+        $result = $collection->lastN(2)->toList();
         $this->assertEquals([4, 5], $result);
 
-        $result = $collection->lastN(1)->toArray();
+        $collection = new Collection(new CountableIterator(range(0, 5)));
+        $result = $collection->lastN(1)->toList();
         $this->assertEquals([5], $result);
     }