Not setting the cookie timeout, it is better if the user can control …

…this setting Fixes #4239
cakephp · Aug 12, 2014 · 5bf16ed · 5bf16ed
1 parent cd5fb7e
commit 5bf16ed
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/Network/Session.php b/src/Network/Session.php
@@ -191,7 +191,6 @@ protected static function _defaultConfig($name) {
  */
 	public function __construct(array $config = []) {
 		if (isset($config['timeout'])) {
-			$config['ini']['session.cookie_lifetime'] = 60 * $config['timeout'];
 			$config['ini']['session.gc_maxlifetime'] = 60 * $config['timeout'];
 		}
 

diff --git a/tests/TestCase/Network/SessionTest.php b/tests/TestCase/Network/SessionTest.php
@@ -439,7 +439,7 @@ public function testCookieTimeoutFallback() {
 		];
 
 		new Session($config);
-		$this->assertEquals(400 * 60, ini_get('session.cookie_lifetime'));
+		$this->assertEquals(0, ini_get('session.cookie_lifetime'));
 		$this->assertEquals(400 * 60, ini_get('session.gc_maxlifetime'));
 	}