From 5dc7024af5b4744766ecd394e910d6160239dc8b Mon Sep 17 00:00:00 2001 From: Travis Rowland Date: Mon, 17 Apr 2017 02:17:28 -0700 Subject: [PATCH] Merging some unset calls for better control flow --- src/Datasource/EntityTrait.php | 3 +-- src/Http/ServerRequest.php | 3 +-- src/ORM/Rule/ExistsIn.php | 3 +-- src/Utility/Hash.php | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/Datasource/EntityTrait.php b/src/Datasource/EntityTrait.php index 188d4521cbd..5baa50fd3c6 100644 --- a/src/Datasource/EntityTrait.php +++ b/src/Datasource/EntityTrait.php @@ -391,8 +391,7 @@ public function unsetProperty($property) { $property = (array)$property; foreach ($property as $p) { - unset($this->_properties[$p]); - unset($this->_dirty[$p]); + unset($this->_properties[$p], $this->_dirty[$p]); } return $this; diff --git a/src/Http/ServerRequest.php b/src/Http/ServerRequest.php index 90c29138d95..97b90bbacc6 100644 --- a/src/Http/ServerRequest.php +++ b/src/Http/ServerRequest.php @@ -387,8 +387,7 @@ protected function _processPost($data) protected function _processGet($query, $queryString = '') { $unsetUrl = '/' . str_replace(['.', ' '], '_', urldecode($this->url)); - unset($query[$unsetUrl]); - unset($query[$this->base . $unsetUrl]); + unset($query[$unsetUrl], $query[$this->base . $unsetUrl]); if (strlen($queryString)) { parse_str($queryString, $queryArgs); $query += $queryArgs; diff --git a/src/ORM/Rule/ExistsIn.php b/src/ORM/Rule/ExistsIn.php index c8f2faca84a..b3730787af5 100644 --- a/src/ORM/Rule/ExistsIn.php +++ b/src/ORM/Rule/ExistsIn.php @@ -118,8 +118,7 @@ public function __invoke(EntityInterface $entity, array $options) $schema = $source->getSchema(); foreach ($this->_fields as $i => $field) { if ($schema->column($field) && $schema->isNullable($field) && $entity->get($field) === null) { - unset($bindingKey[$i]); - unset($this->_fields[$i]); + unset($bindingKey[$i], $this->_fields[$i]); } } } diff --git a/src/Utility/Hash.php b/src/Utility/Hash.php index 685e460b619..b20d2acaa80 100644 --- a/src/Utility/Hash.php +++ b/src/Utility/Hash.php @@ -1077,8 +1077,7 @@ public static function diff(array $data, array $compare) $intersection = array_intersect_key($data, $compare); while (($key = key($intersection)) !== null) { if ($data[$key] == $compare[$key]) { - unset($data[$key]); - unset($compare[$key]); + unset($data[$key], $compare[$key]); } next($intersection); }