Add test for session.close

cakephp · Aug 28, 2018 · 64e46c6 · 64e46c6
1 parent 91e19a5
commit 64e46c6
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/Http/Session.php b/src/Http/Session.php
@@ -369,7 +369,7 @@ public function start()
     }
 
     /**
-     * Write datas and close the session
+     * Write data and close the session
      *
      * @return bool True if session was started
      */

diff --git a/tests/TestCase/Http/SessionTest.php b/tests/TestCase/Http/SessionTest.php
@@ -19,6 +19,7 @@
 use Cake\Http\Session\CacheSession;
 use Cake\Http\Session\DatabaseSession;
 use Cake\TestSuite\TestCase;
+use RuntimeException;
 
 /**
  * TestCacheSession
@@ -304,6 +305,25 @@ public function testStarted()
         $this->assertTrue($session->started());
     }
 
+    /**
+     * test close method
+     *
+     * @return void
+     */
+    public function testCloseFailure()
+    {
+        $session = new Session();
+        $session->started();
+        $this->assertTrue($session->start());
+        try {
+            $session->close();
+        } catch (RuntimeException $e) {
+            // closing the session in CLI should raise an error
+            // and won't close the session.
+            $this->assertTrue($session->started());
+        }
+    }
+
     /**
      * testClear method
      *