Skip to content

Commit

Permalink
$expected is the first arg for assertEqual
Browse files Browse the repository at this point in the history
having it the wrong way round makes the error messages quite confusing
  • Loading branch information
AD7six committed May 16, 2011
1 parent e95d6a3 commit 6b77e73
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions lib/Cake/Test/Case/View/ViewTest.php
Expand Up @@ -234,11 +234,11 @@ function testPluginGetTemplate() {

$expected = CakePlugin::path('TestPlugin') . 'View' . DS .'Tests' . DS .'index.ctp';
$result = $View->getViewFileName('index');
$this->assertEqual($result, $expected);
$this->assertEqual($expected, $result);

$expected = CakePlugin::path('TestPlugin') . 'View' . DS . 'Layouts' . DS .'default.ctp';
$result = $View->getLayoutFileName();
$this->assertEqual($result, $expected);
$this->assertEqual($expected, $result);
}

/**
Expand Down Expand Up @@ -290,11 +290,11 @@ function testCamelCasePluginGetTemplate() {
$pluginPath = CakePlugin::path('TestPlugin');
$expected = CAKE . 'Test' . DS . 'test_app' . DS . 'Plugin' . DS .'TestPlugin' . DS . 'View' . DS .'Tests' . DS .'index.ctp';
$result = $View->getViewFileName('index');
$this->assertEqual($result, $expected);
$this->assertEqual($expected, $result);

$expected = $pluginPath. 'View' . DS . 'Layouts' . DS .'default.ctp';
$result = $View->getLayoutFileName();
$this->assertEqual($result, $expected);
$this->assertEqual($expected, $result);
}

/**
Expand All @@ -314,30 +314,30 @@ function testGetTemplate() {

$expected = CAKE . 'Test' . DS . 'test_app' . DS . 'View' . DS .'Pages' . DS .'home.ctp';
$result = $View->getViewFileName('home');
$this->assertEqual($result, $expected);
$this->assertEqual($expected, $result);

$expected = CAKE . 'Test' . DS . 'test_app' . DS . 'View' . DS .'Posts' . DS .'index.ctp';
$result = $View->getViewFileName('/Posts/index');
$this->assertEqual($result, $expected);
$this->assertEqual($expected, $result);

$expected = CAKE . 'Test' . DS . 'test_app' . DS . 'View' . DS .'Posts' . DS .'index.ctp';
$result = $View->getViewFileName('../Posts/index');
$this->assertEqual($result, $expected);
$this->assertEqual($expected, $result);

$expected = CAKE . 'Test' . DS . 'test_app' . DS . 'View' . DS . 'Layouts' . DS .'default.ctp';
$result = $View->getLayoutFileName();
$this->assertEqual($result, $expected);
$this->assertEqual($expected, $result);

$View->layoutPath = 'rss';
$expected = CAKE . 'Test' . DS . 'test_app' . DS . 'View' . DS . 'Layouts' . DS . 'rss' . DS . 'default.ctp';
$result = $View->getLayoutFileName();
$this->assertEqual($result, $expected);
$this->assertEqual($expected, $result);

$View->layoutPath = 'emails' . DS . 'html';
$expected = CAKE . 'Test' . DS . 'test_app' . DS . 'View' . DS . 'Layouts' . DS . 'emails' . DS . 'html' . DS . 'default.ctp';
$result = $View->getLayoutFileName();

$this->assertEqual($result, $expected);
$this->assertEqual($expected, $result);
}

/**
Expand Down Expand Up @@ -764,7 +764,7 @@ function testViewFileName() {

$expected = CAKE . 'Test' . DS . 'test_app' . DS . 'View' . DS .'Posts' . DS .'index.ctp';
$result = $View->getViewFileName('../Posts/index');
$this->assertEqual($result, $expected);
$this->assertEqual($expected, $result);

}

Expand Down

0 comments on commit 6b77e73

Please sign in to comment.