Making HelperRegistry accept a ConsoleIO in a setter

Passing it in the contructor was problematic as both classes depend on each other.
cakephp · Jun 17, 2015 · 6ebd6e1 · 6ebd6e1
1 parent 655dafd
commit 6ebd6e1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/Console/ConsoleIo.php b/src/Console/ConsoleIo.php
@@ -107,7 +107,8 @@ public function __construct(ConsoleOutput $out = null, ConsoleOutput $err = null
         $this->_out = $out ? $out : new ConsoleOutput('php://stdout');
         $this->_err = $err ? $err : new ConsoleOutput('php://stderr');
         $this->_in = $in ? $in : new ConsoleInput('php://stdin');
-        $this->_helpers = $helpers ? $helpers : new HelperRegistry($this);
+        $this->_helpers = $helpers ? $helpers : new HelperRegistry();
+        $this->_helpers->setIo($this);
     }
 
     /**

diff --git a/src/Console/HelperRegistry.php b/src/Console/HelperRegistry.php
@@ -34,11 +34,11 @@ class HelperRegistry extends ObjectRegistry
     protected $_io;
 
     /**
-     * Constructor
+     * Sets The IO instance that should be passed to the shell helpers
      *
      * @param \Cake\Console\ConsoleIo $io An io instance.
      */
-    public function __construct(ConsoleIo $io)
+    public function setIo(ConsoleIo $io)
     {
         $this->_io = $io;
     }

diff --git a/tests/TestCase/Console/HelperRegistryTest.php b/tests/TestCase/Console/HelperRegistryTest.php
@@ -35,7 +35,8 @@ public function setUp()
         parent::setUp();
         Configure::write('App.namespace', 'TestApp');
         $io = $this->getMock('Cake\Console\ConsoleIo', [], [], '', false);
-        $this->helpers = new HelperRegistry($io);
+        $this->helpers = new HelperRegistry();
+        $this->helpers->setIo($io);
     }
 
     /**