Skip to content

Commit

Permalink
Refactoring CakeTestCase to remove fixture specific code and use the …
Browse files Browse the repository at this point in the history 
…new class CakeFixtureManager.

It lacks support to auto-drop tables after test case end, but it is already usable for testing
  • Loading branch information
@lorenzo
lorenzo committed May 7, 2010
1 parent ef142b1 commit 7124e6d
Showing 1 changed file with 18 additions and 185 deletions.
203 changes: 18 additions & 185 deletions cake/tests/lib/cake_test_case.php
View file
Expand Up @@ -20,6 +20,7 @@
if (!class_exists('dispatcher')) {
require CAKE . 'dispatcher.php';
}
require_once CAKE_TESTS_LIB . 'cake_fixture_manager.php';
require_once CAKE_TESTS_LIB . 'cake_test_model.php';
require_once CAKE_TESTS_LIB . 'cake_test_fixture.php';
App::import('Vendor', 'simpletest' . DS . 'unit_tester');
Expand Down Expand Up @@ -133,6 +134,12 @@ class CakeTestCase extends PHPUnit_Framework_TestCase {
*/
private $__savedGetData = array();

public function __construct($name = null, array $data = array(), $dataName = '') {
parent::__construct($name, $data, $dataName);
if (!empty($this->fixtures)) {
CakeFixtureManager::fixturize($this);
}
}
/**
* Called when a test case (group of methods) is about to start (to be overriden when needed.)
*
Expand Down Expand Up @@ -387,56 +394,11 @@ public function runTestAction($url, $params = array()) {
* @param string $method Test method just started.
* @return void
*/
public function before($method) {
parent::before($method);

if (isset($this->fixtures) && (!is_array($this->fixtures) || empty($this->fixtures))) {
unset($this->fixtures);
}

// Set up DB connection
if (isset($this->fixtures) && strtolower($method) == 'start') {
$this->_initDb();
$this->_loadFixtures();
}

// Create records
if (isset($this->_fixtures) && isset($this->db) && !in_array(strtolower($method), array('start', 'end')) && $this->__truncated && $this->autoFixtures == true) {
foreach ($this->_fixtures as $fixture) {
$inserts = $fixture->insert($this->db);
}
}

if (!in_array(strtolower($method), $this->methods)) {
$this->startTest($method);
}
}

/**
* Runs as first test to create tables.
*
* @return void
*/
public function start() {
if (isset($this->_fixtures) && isset($this->db)) {
Configure::write('Cache.disable', true);
$cacheSources = $this->db->cacheSources;
$this->db->cacheSources = false;
$sources = $this->db->listSources();
$this->db->cacheSources = $cacheSources;

if (!$this->dropTables) {
return;
}
foreach ($this->_fixtures as $fixture) {
$table = $this->db->config['prefix'] . $fixture->table;
if (in_array($table, $sources)) {
$fixture->drop($this->db);
$fixture->create($this->db);
} elseif (!in_array($table, $sources)) {
$fixture->create($this->db);
}
}
protected function assertPreConditions() {
parent::assertPreConditions();
CakeFixtureManager::load($this);
if (!in_array(strtolower($this->getName()), $this->methods)) {
$this->startTest($this->getName());
}
}

Expand Down Expand Up @@ -467,24 +429,12 @@ public function end() {
* @param string $method Test method just finished.
* @return void
*/
public function after($method) {
$isTestMethod = !in_array(strtolower($method), array('start', 'end'));

if (isset($this->_fixtures) && isset($this->db) && $isTestMethod) {
foreach ($this->_fixtures as $fixture) {
$fixture->truncate($this->db);
}
$this->__truncated = true;
} else {
$this->__truncated = false;
protected function assertPostConditions() {
parent::assertPostConditions();
CakeFixtureManager::unload($this);
if (!in_array(strtolower($this->getName()), $this->methods)) {
$this->endTest($this->getName());
}

if (!in_array(strtolower($method), $this->methods)) {
$this->endTest($method);
}
$this->_should_skip = false;

parent::after($method);
}

/**
Expand All @@ -501,14 +451,6 @@ public function getTests() {
);
}

/**
* Accessor for checking whether or not fixtures were truncated
*
* @return void
*/
public function getTruncated() {
return $this->__truncated;
}
/**
* Chooses which fixtures to load for a given test
*
Expand All @@ -521,14 +463,7 @@ public function getTruncated() {
function loadFixtures() {
$args = func_get_args();
foreach ($args as $class) {
if (isset($this->_fixtureClassMap[$class])) {
$fixture = $this->_fixtures[$this->_fixtureClassMap[$class]];

$fixture->truncate($this->db);
$fixture->insert($this->db);
} else {
trigger_error(sprintf(__('Referenced fixture class %s not found', true), $class), E_USER_WARNING);
}
CakeFixtureManager::loadSingle($class);
}
}

Expand Down Expand Up @@ -690,108 +625,6 @@ public function assertTags($string, $expected, $fullDebug = false) {
return $this->assertTrue(true, '%s');
}

/**
* Initialize DB connection.
*
* @return void
*/
protected function _initDb() {
$testDbAvailable = in_array('test', array_keys(ConnectionManager::enumConnectionObjects()));

$_prefix = null;

if ($testDbAvailable) {
// Try for test DB
restore_error_handler();
@$db = ConnectionManager::getDataSource('test');
set_error_handler('simpleTestErrorHandler');
$testDbAvailable = $db->isConnected();
}

// Try for default DB
if (!$testDbAvailable) {
$db = ConnectionManager::getDataSource('default');
$_prefix = $db->config['prefix'];
$db->config['prefix'] = 'test_suite_';
}

ConnectionManager::create('test_suite', $db->config);
$db->config['prefix'] = $_prefix;

// Get db connection
$this->db = ConnectionManager::getDataSource('test_suite');
$this->db->cacheSources = false;

ClassRegistry::config(array('ds' => 'test_suite'));
}

/**
* Load fixtures specified in public $fixtures.
*
* @return void
*/
protected function _loadFixtures() {
if (!isset($this->fixtures) || empty($this->fixtures)) {
return;
}

if (!is_array($this->fixtures)) {
$this->fixtures = array_map('trim', explode(',', $this->fixtures));
}

$this->_fixtures = array();

foreach ($this->fixtures as $index => $fixture) {
$fixtureFile = null;

if (strpos($fixture, 'core.') === 0) {
$fixture = substr($fixture, strlen('core.'));
foreach (App::core('cake') as $key => $path) {
$fixturePaths[] = $path . 'tests' . DS . 'fixtures';
}
} elseif (strpos($fixture, 'app.') === 0) {
$fixture = substr($fixture, strlen('app.'));
$fixturePaths = array(
TESTS . 'fixtures',
VENDORS . 'tests' . DS . 'fixtures'
);
} elseif (strpos($fixture, 'plugin.') === 0) {
$parts = explode('.', $fixture, 3);
$pluginName = $parts[1];
$fixture = $parts[2];
$fixturePaths = array(
App::pluginPath($pluginName) . 'tests' . DS . 'fixtures',
TESTS . 'fixtures',
VENDORS . 'tests' . DS . 'fixtures'
);
} else {
$fixturePaths = array(
TESTS . 'fixtures',
VENDORS . 'tests' . DS . 'fixtures',
TEST_CAKE_CORE_INCLUDE_PATH . DS . 'cake' . DS . 'tests' . DS . 'fixtures'
);
}

foreach ($fixturePaths as $path) {
if (is_readable($path . DS . $fixture . '_fixture.php')) {
$fixtureFile = $path . DS . $fixture . '_fixture.php';
break;
}
}

if (isset($fixtureFile)) {
require_once($fixtureFile);
$fixtureClass = Inflector::camelize($fixture) . 'Fixture';
$this->_fixtures[$this->fixtures[$index]] =& new $fixtureClass($this->db);
$this->_fixtureClassMap[Inflector::camelize($fixture)] = $this->fixtures[$index];
}
}

if (empty($this->_fixtures)) {
unset($this->_fixtures);
}
}

/**
* Generates all permutation of an array $items and returns them in a new array.
*
Expand Down

0 comments on commit 7124e6d

Please sign in to comment.