Fix usage of 'escape' => false.

cakephp · Apr 25, 2018 · 74792f6 · 74792f6
1 parent 9aa5065
commit 74792f6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/View/Helper/HtmlHelper.php b/src/View/Helper/HtmlHelper.php
@@ -1096,7 +1096,7 @@ public function div($class = null, $text = null, array $options = [])
      */
     public function para($class, $text, array $options = [])
     {
-        if (isset($options['escape'])) {
+        if (!empty($options['escape'])) {
             $text = h($text);
         }
         if ($class && !empty($class)) {

diff --git a/tests/TestCase/View/Helper/HtmlHelperTest.php b/tests/TestCase/View/Helper/HtmlHelperTest.php
@@ -2055,6 +2055,10 @@ public function testPara()
         $result = $this->Html->para('class-name', '<text>', ['escape' => true]);
         $expected = ['p' => ['class' => 'class-name'], '&lt;text&gt;', '/p'];
         $this->assertHtml($expected, $result);
+
+        $result = $this->Html->para('class-name', 'text"', ['escape' => false]);
+        $expected = ['p' => ['class' => 'class-name'], 'text"', '/p'];
+        $this->assertHtml($expected, $result);
     }
 
     /**