Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactoring lastInsertId. It never made sense to have the method in the
connection object itself other than to mimic PDO. This enables users to get the last insertion id directly from the insert query statement, which is specially useful when using postgres as it will return the full row inserted, thus avoiding any posibility for race conditions and the hassle of having a map of sequences in the driver itself
- Loading branch information
Showing
6 changed files
with
91 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
Cake/Test/TestCase/Database/Statement/StatementDecoratorTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
<?php | ||
/** | ||
* PHP Version 5.4 | ||
* | ||
* CakePHP(tm) : Rapid Development Framework (http://cakephp.org) | ||
* Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org) | ||
* | ||
* Licensed under The MIT License | ||
* For full copyright and license information, please see the LICENSE.txt | ||
* Redistributions of files must retain the above copyright notice. | ||
* | ||
* @copyright Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org) | ||
* @link http://cakephp.org CakePHP(tm) Project | ||
* @since CakePHP(tm) v 3.0.0 | ||
* @license MIT License (http://www.opensource.org/licenses/mit-license.php) | ||
*/ | ||
namespace Cake\Test\TestCase\Database\Statement; | ||
|
||
use Cake\Database\Statement\StatementDecorator; | ||
use Cake\TestSuite\TestCase; | ||
use \PDO; | ||
|
||
/** | ||
* Tests StatementDecorator class | ||
* | ||
*/ | ||
class StatemetDecoratorTest extends TestCase { | ||
|
||
/** | ||
* Tests that calling lastInsertId will proxy it to | ||
* the driver's lastInsertId method | ||
* | ||
* @return void | ||
*/ | ||
public function testLastInsertId() { | ||
$statement = $this->getMock('\PDOStatement'); | ||
$driver = $this->getMock('\Cake\Database\Driver'); | ||
$statement = new StatementDecorator($statement, $driver); | ||
|
||
$driver->expects($this->once())->method('lastInsertId') | ||
->with('users') | ||
->will($this->returnValue(2)); | ||
$this->assertEquals(2, $statement->lastInsertId('users')); | ||
} | ||
|
||
/** | ||
* Tests that calling lastInsertId will get the | ||
* | ||
* @return void | ||
*/ | ||
public function testLastInsertIdWithReturning() { | ||
$internal = $this->getMock('\PDOStatement'); | ||
$driver = $this->getMock('\Cake\Database\Driver'); | ||
$statement = new StatementDecorator($internal, $driver); | ||
|
||
$internal->expects($this->once())->method('fetch') | ||
->with('assoc') | ||
->will($this->returnValue(['id' => 2])); | ||
$driver->expects($this->never())->method('lastInsertId'); | ||
$this->assertEquals(2, $statement->lastInsertId('users', 'id')); | ||
} | ||
|
||
} |