Optimize DashedRoute and Inflector::variable().

Reduce the number of function calls done for micro perf gains.
cakephp · Jan 22, 2016 · 7fe3621 · 7fe3621
1 parent bc1ec25
commit 7fe3621
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/Routing/Route/DashedRoute.php b/src/Routing/Route/DashedRoute.php
@@ -65,11 +65,7 @@ public function parse($url)
             return false;
         }
         if (!empty($params['controller'])) {
-            $params['controller'] = Inflector::camelize(str_replace(
-                '-',
-                '_',
-                $params['controller']
-            ));
+            $params['controller'] = Inflector::camelize($params['controller'], '-');
         }
         if (!empty($params['plugin'])) {
             $params['plugin'] = $this->_camelizePlugin($params['plugin']);

diff --git a/src/Utility/Inflector.php b/src/Utility/Inflector.php
@@ -720,7 +720,7 @@ public static function variable($string)
         if ($result === false) {
             $camelized = static::camelize(static::underscore($string));
             $replace = strtolower(substr($camelized, 0, 1));
-            $result = preg_replace('/\\w/', $replace, $camelized, 1);
+            $result = $replace . substr($camelized, 1);
             static::_cache(__FUNCTION__, $string, $result);
         }