Skip to content

Commit

Permalink
replaces validator 'between' with 'lengthBetween'
Browse files Browse the repository at this point in the history
  • Loading branch information
Schlaefer committed May 13, 2014
1 parent 4848b63 commit 815838f
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
22 changes: 11 additions & 11 deletions lib/Cake/Test/Case/Model/ModelValidationTest.php
Expand Up @@ -1844,7 +1844,7 @@ public function testArrayAccessSet() {

$set = array(
'numeric' => array('rule' => 'numeric', 'allowEmpty' => false),
'range' => array('rule' => array('between', 1, 5), 'allowEmpty' => false),
'between' => array('rule' => array('lengthBetween', 1, 5), 'allowEmpty' => false),
);
$Validator['other'] = $set;
$rules = $Validator['other'];
Expand All @@ -1853,7 +1853,7 @@ public function testArrayAccessSet() {
$validators = $rules->getRules();
$this->assertCount(2, $validators);
$this->assertEquals('numeric', $validators['numeric']->rule);
$this->assertEquals(array('between', 1, 5), $validators['range']->rule);
$this->assertEquals(array('lengthBetween', 1, 5), $validators['between']->rule);

$Validator['new'] = new CakeValidationSet('new', $set, array());
$rules = $Validator['new'];
Expand All @@ -1862,7 +1862,7 @@ public function testArrayAccessSet() {
$validators = $rules->getRules();
$this->assertCount(2, $validators);
$this->assertEquals('numeric', $validators['numeric']->rule);
$this->assertEquals(array('between', 1, 5), $validators['range']->rule);
$this->assertEquals(array('lengthBetween', 1, 5), $validators['between']->rule);
}

/**
Expand Down Expand Up @@ -1917,7 +1917,7 @@ public function testCount() {

$set = array(
'numeric' => array('rule' => 'numeric', 'allowEmpty' => false),
'range' => array('rule' => array('between', 1, 5), 'allowEmpty' => false),
'range' => array('rule' => array('lengthBetween', 1, 5), 'allowEmpty' => false),
);
$Validator['other'] = $set;
$this->assertCount(4, $Validator);
Expand All @@ -1938,14 +1938,14 @@ public function testAddRule() {
$Validator = $TestModel->validator();

$Validator->add('other', 'numeric', array('rule' => 'numeric', 'allowEmpty' => false));
$Validator->add('other', 'range', array('rule' => array('between', 1, 5), 'allowEmpty' => false));
$Validator->add('other', 'between', array('rule' => array('lengthBetween', 1, 5), 'allowEmpty' => false));
$rules = $Validator['other'];
$this->assertEquals('other', $rules->field);

$validators = $rules->getRules();
$this->assertCount(2, $validators);
$this->assertEquals('numeric', $validators['numeric']->rule);
$this->assertEquals(array('between', 1, 5), $validators['range']->rule);
$this->assertEquals(array('lengthBetween', 1, 5), $validators['between']->rule);
}

/**
Expand All @@ -1962,13 +1962,13 @@ public function testRemoveRule() {
$this->assertFalse(isset($Validator['title']));

$Validator->add('other', 'numeric', array('rule' => 'numeric', 'allowEmpty' => false));
$Validator->add('other', 'range', array('rule' => array('between', 1, 5), 'allowEmpty' => false));
$Validator->add('other', 'between', array('rule' => array('lengthBetween', 1, 5), 'allowEmpty' => false));
$this->assertTrue(isset($Validator['other']));

$Validator->remove('other', 'numeric');
$this->assertTrue(isset($Validator['other']));
$this->assertFalse(isset($Validator['other']['numeric']));
$this->assertTrue(isset($Validator['other']['range']));
$this->assertTrue(isset($Validator['other']['between']));
}

/**
Expand Down Expand Up @@ -2126,7 +2126,7 @@ public function testAddMultipleRules() {

$set = array(
'numeric' => array('rule' => 'numeric', 'allowEmpty' => false),
'range' => array('rule' => array('between', 1, 5), 'allowEmpty' => false),
'between' => array('rule' => array('lengthBetween', 1, 5), 'allowEmpty' => false),
);

$Validator->add('other', $set);
Expand All @@ -2136,11 +2136,11 @@ public function testAddMultipleRules() {
$validators = $rules->getRules();
$this->assertCount(2, $validators);
$this->assertEquals('numeric', $validators['numeric']->rule);
$this->assertEquals(array('between', 1, 5), $validators['range']->rule);
$this->assertEquals(array('lengthBetween', 1, 5), $validators['between']->rule);

$set = new CakeValidationSet('other', array(
'a' => array('rule' => 'numeric', 'allowEmpty' => false),
'b' => array('rule' => array('between', 1, 5), 'allowEmpty' => false),
'b' => array('rule' => array('lengthBetween', 1, 5), 'allowEmpty' => false),
));

$Validator->add('other', $set);
Expand Down
2 changes: 1 addition & 1 deletion lib/Cake/Test/test_app/Model/Extract.php
Expand Up @@ -36,7 +36,7 @@ class Extract extends AppModel {
'message' => 'double "quoted" validation'
),
'between' => array(
'rule' => array('between', 5, 15),
'rule' => array('lengthBetween', 5, 15),
'message' => "single 'quoted' validation"
)
),
Expand Down
2 changes: 1 addition & 1 deletion lib/Cake/Test/test_app/Model/PersisterOne.php
Expand Up @@ -38,7 +38,7 @@ class PersisterOne extends AppModel {
'message' => 'Post title is required'
),
'between' => array(
'rule' => array('between', 5, 15),
'rule' => array('lengthBetween', 5, 15),
'message' => array('You may enter up to %s chars (minimum is %s chars)', 14, 6)
)
),
Expand Down

0 comments on commit 815838f

Please sign in to comment.