Removing the useless string callback from the findOrCreate

cakephp · Apr 25, 2016 · 8b36769 · 8b36769
1 parent 656adb7
commit 8b36769
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 17 deletions.
diff --git a/src/ORM/Table.php b/src/ORM/Table.php
@@ -1245,12 +1245,6 @@ protected function _getFindOrCreateQuery($search)
         if ($search instanceof Query) {
             return $search;
         }
-        if (is_string($search)) {
-            if (method_exists($this, $search)) {
-                return $this->{$search}();
-            }
-            throw new InvalidArgumentException('Method `' . $search . '` does not exist!');
-        }
         return $this->find()->where($search);
     }
 

diff --git a/tests/TestCase/ORM/TableTest.php b/tests/TestCase/ORM/TableTest.php
@@ -5390,17 +5390,6 @@ function ($article) {
         $this->assertEquals(2, $article->author_id);
     }
 
-    /**
-     * Test that exceptions from the findOrCreate are thrown.
-     *
-     * @expectedException \InvalidArgumentException
-     */
-    public function testFindOrCreateException()
-    {
-        $articles = TableRegistry::get('Articles');
-        $articles->findOrCreate('doesNotExist');
-    }
-
     /**
      * Test that creating a table fires the initialize event.
      *