Adding test and fix to ensure the debug = 0, log = false leaves error…

…_reporting set to 0. Fixes #89
cakephp · Dec 11, 2009 · 904b9f5 · 904b9f5
1 parent f26d5ef
commit 904b9f5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/cake/libs/configure.php b/cake/libs/configure.php
@@ -109,7 +109,7 @@ function write($config, $value = null) {
 			}
 		}
 
-		if (isset($config['debug'])) {
+		if (isset($config['debug']) || isset($config['log'])) {
 			$reporting = 0;
 			if ($_this->debug) {
 				if (!class_exists('Debugger')) {

diff --git a/cake/tests/cases/libs/configure.test.php b/cake/tests/cases/libs/configure.test.php
@@ -176,6 +176,11 @@ function testInteractionOfDebugAndLog() {
 		Configure::write('debug', 2);
 		$this->assertEqual(ini_get('error_reporting'), E_ALL & ~E_DEPRECATED);
 		$this->assertEqual(ini_get('display_errors'), 1);
+
+		Configure::write('debug', 0);
+		Configure::write('log', false);
+		$this->assertEqual(ini_get('error_reporting'), 0);
+		$this->assertEqual(ini_get('display_errors'), 0);
 	}
 
 /**