From a02ab675216fac7f6fd7790bed8fac20f129c6f8 Mon Sep 17 00:00:00 2001 From: euromark Date: Fri, 3 Jan 2014 12:42:52 +0100 Subject: [PATCH] unify exception and error handling. --- lib/Cake/Error/ExceptionRenderer.php | 18 +++++++++--------- .../Test/test_app/View/Errors/error400.ctp | 2 +- .../Test/test_app/View/Errors/error500.ctp | 2 +- lib/Cake/View/Errors/pdo_error.ctp | 2 +- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/Cake/Error/ExceptionRenderer.php b/lib/Cake/Error/ExceptionRenderer.php index e6b858057fd..a4b824cd199 100644 --- a/lib/Cake/Error/ExceptionRenderer.php +++ b/lib/Cake/Error/ExceptionRenderer.php @@ -189,9 +189,9 @@ protected function _cakeError(CakeException $error) { $this->controller->set(array( 'code' => $code, 'url' => h($url), - 'name' => h($error->getMessage()), + 'message' => h($error->getMessage()), 'error' => $error, - '_serialize' => array('code', 'url', 'name') + '_serialize' => array('code', 'url', 'message') )); $this->controller->set($error->getAttributes()); $this->_outputMessage($this->template); @@ -211,10 +211,10 @@ public function error400($error) { $url = $this->controller->request->here(); $this->controller->response->statusCode($error->getCode()); $this->controller->set(array( - 'name' => h($message), 'url' => h($url), + 'message' => h($message), 'error' => $error, - '_serialize' => array('name', 'url') + '_serialize' => array('url', 'message') )); $this->_outputMessage('error400'); } @@ -234,10 +234,10 @@ public function error500($error) { $code = ($error->getCode() > 500 && $error->getCode() < 506) ? $error->getCode() : 500; $this->controller->response->statusCode($code); $this->controller->set(array( - 'name' => h($message), - 'message' => h($url), + 'url' => h($url), + 'message' => h($message), 'error' => $error, - '_serialize' => array('name', 'message') + '_serialize' => array('url', 'message') )); $this->_outputMessage('error500'); } @@ -255,9 +255,9 @@ public function pdoError(PDOException $error) { $this->controller->set(array( 'code' => $code, 'url' => h($url), - 'name' => h($error->getMessage()), + 'message' => h($error->getMessage()), 'error' => $error, - '_serialize' => array('code', 'url', 'name', 'error') + '_serialize' => array('code', 'url', 'message', 'error') )); $this->_outputMessage($this->template); } diff --git a/lib/Cake/Test/test_app/View/Errors/error400.ctp b/lib/Cake/Test/test_app/View/Errors/error400.ctp index aa817e75cb4..f3692628af3 100644 --- a/lib/Cake/Test/test_app/View/Errors/error400.ctp +++ b/lib/Cake/Test/test_app/View/Errors/error400.ctp @@ -1,4 +1,4 @@ -

+

: +

: diff --git a/lib/Cake/View/Errors/pdo_error.ctp b/lib/Cake/View/Errors/pdo_error.ctp index 56361732e3f..1efdb4b7c5f 100644 --- a/lib/Cake/View/Errors/pdo_error.ctp +++ b/lib/Cake/View/Errors/pdo_error.ctp @@ -19,7 +19,7 @@

: - +

queryString)) : ?>