Fix for #8942 customized redirect route class (#9010)

cakephp · Jun 21, 2016 · a0d362f · a0d362f
1 parent 97e071f
commit a0d362f
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/Routing/Router.php b/src/Routing/Router.php
@@ -222,7 +222,7 @@ public static function connect($route, $defaults = [], $options = [])
      */
     public static function redirect($route, $url, $options = [])
     {
-        $options['routeClass'] = 'Cake\Routing\Route\RedirectRoute';
+        $options += ['routeClass' => 'Cake\Routing\Route\RedirectRoute'];
         if (is_string($url)) {
             $url = ['redirect' => $url];
         }

diff --git a/tests/TestCase/Routing/RouterTest.php b/tests/TestCase/Routing/RouterTest.php
@@ -2869,6 +2869,28 @@ public function testRedirect()
         $this->assertInstanceOf('Cake\Routing\Route\RedirectRoute', $route);
     }
 
+    /**
+     * Test that redirect() works with another route class.
+     *
+     * @return void
+     */
+    public function testRedirectWithAnotherRouteClass()
+    {
+        $route1 = $this->getMockBuilder('Cake\Routing\Route\RedirectRoute')
+            ->setConstructorArgs(['/mobile\''])
+            ->getMock();
+        $class = '\\' . get_class($route1);
+
+        Router::redirect('/mobile', '/', [
+            'status' => 301,
+            'routeClass' => $class
+        ]);
+
+        $routes = Router::routes();
+        $route = $routes[0];
+        $this->assertInstanceOf($class, $route);
+    }
+
     /**
      * Test that the compatibility method for incoming urls works.
      *