From a34358faa43c9578fa47bdc08ef237bc2e96e246 Mon Sep 17 00:00:00 2001 From: Jose Lorenzo Rodriguez Date: Tue, 21 Jun 2011 14:29:18 -0430 Subject: [PATCH] Fixing FormAuthenticateTest for Sqlsrv --- lib/Cake/Model/Datasource/Database/Sqlserver.php | 15 +-------------- .../Case/Console/Command/Task/ProjectTaskTest.php | 2 +- .../Component/Auth/FormAuthenticateTest.php | 3 ++- 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/lib/Cake/Model/Datasource/Database/Sqlserver.php b/lib/Cake/Model/Datasource/Database/Sqlserver.php index 71ebd21bb94..3f7e7ae0891 100644 --- a/lib/Cake/Model/Datasource/Database/Sqlserver.php +++ b/lib/Cake/Model/Datasource/Database/Sqlserver.php @@ -517,20 +517,7 @@ public function renderStatement($type, $data) { $offset = intval($offset[1]) + intval($limitVal[1]); $rOrder = $this->__switchSort($order); list($order2, $rOrder) = array($this->__mapFields($order), $this->__mapFields($rOrder)); - $limit2 = str_replace('TOP', '', $limit); - if (!$order) { - $order = 'ORDER BY (SELECT NULL)'; - } - - $pagination = " - SELECT {$limit} * FROM ( - SELECT {$fields}, ROW_NUMBER() OVER ({$order}) AS ssma\$rownum - FROM {$table} {$alias} {$joins} {$conditions} {$group} - ) AS ssma\$sub1 - WHERE ssma\$sub1.[ssma\$rownum] > {$limit2} - ORDER BY ssma\$sub1.[ssma\$rownum] - "; - return $pagination; + return "SELECT * FROM (SELECT {$limit} * FROM (SELECT TOP {$offset} {$fields} FROM {$table} {$alias} {$joins} {$conditions} {$group} {$order}) AS Set1 {$rOrder}) AS Set2 {$order2}"; } else { return "SELECT {$limit} {$fields} FROM {$table} {$alias} {$joins} {$conditions} {$group} {$order}"; } diff --git a/lib/Cake/Test/Case/Console/Command/Task/ProjectTaskTest.php b/lib/Cake/Test/Case/Console/Command/Task/ProjectTaskTest.php index fc7714f2e8e..c4e73cf3415 100644 --- a/lib/Cake/Test/Case/Console/Command/Task/ProjectTaskTest.php +++ b/lib/Cake/Test/Case/Console/Command/Task/ProjectTaskTest.php @@ -245,7 +245,7 @@ public function testCakeAdmin() { $this->assertTrue($result); $this->assertEqual(Configure::read('Routing.prefixes'), array('my_prefix')); - $file->delete(); + @$file->delete(); } /** diff --git a/lib/Cake/Test/Case/Controller/Component/Auth/FormAuthenticateTest.php b/lib/Cake/Test/Case/Controller/Component/Auth/FormAuthenticateTest.php index a2d1210b9fc..0b82652ad21 100644 --- a/lib/Cake/Test/Case/Controller/Component/Auth/FormAuthenticateTest.php +++ b/lib/Cake/Test/Case/Controller/Component/Auth/FormAuthenticateTest.php @@ -44,7 +44,8 @@ public function setUp() { 'userModel' => 'User' )); $password = Security::hash('password', null, true); - ClassRegistry::init('User')->updateAll(array('password' => '"' . $password . '"')); + $User = ClassRegistry::init('User'); + $User->updateAll(array('password' => $User->getDataSource()->value($password))); $this->response = $this->getMock('CakeResponse'); }