Make sure the line that will be overwritten in the CLI ProgressHelper…

… does not have a new line feed Otherwise, it is impossible to be sure that the line that will be overwritten can be without any visual glitch. Before this change, visual glitch appeared when using Putty on Windows.
cakephp · Feb 8, 2016 · a6450b0 · a6450b0
1 parent 4c3cc0b
commit a6450b0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/Shell/Helper/ProgressHelper.php b/src/Shell/Helper/ProgressHelper.php
@@ -69,6 +69,8 @@ public function output($args)
         $this->init($args);
 
         $callback = $args['callback'];
+
+        $this->_io->out('', 0);
         while ($this->_progress < $this->_total) {
             $callback($this);
             $this->draw();

diff --git a/tests/TestCase/Shell/Helper/ProgressHelperTest.php b/tests/TestCase/Shell/Helper/ProgressHelperTest.php
@@ -60,6 +60,7 @@ public function testOutputSuccess()
             $progress->increment(20);
         }]);
         $expected = [
+            '',
             '',
             '==============>                                                              20%',
             '',
@@ -90,6 +91,7 @@ public function testOutputSuccessOptions()
             }
         ]);
         $expected = [
+            '',
             '',
             '==>              20%',
             '',