Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
CS fixes
  • Loading branch information
lorenzo committed Oct 10, 2016
1 parent dbbf698 commit abd13e5
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 11 deletions.
3 changes: 2 additions & 1 deletion src/ORM/Association/BelongsTo.php
Expand Up @@ -188,7 +188,8 @@ protected function _joinCondition($options)
*
* @return callable
*/
public function eagerLoader(array $options) {
public function eagerLoader(array $options)
{
$loader = new SelectLoader([
'alias' => $this->alias(),
'sourceAlias' => $this->source()->alias(),
Expand Down
8 changes: 4 additions & 4 deletions src/ORM/Association/BelongsToMany.php
Expand Up @@ -506,7 +506,8 @@ protected function _joinCondition($options)
*
* @return callable
*/
public function eagerLoader(array $options) {
public function eagerLoader(array $options)
{
$name = $this->_junctionAssociationName();
$loader = new SelectWithPivotLoader([
'alias' => $this->alias(),
Expand All @@ -519,11 +520,10 @@ public function eagerLoader(array $options) {
'sort' => $this->sort(),
'junctionAssociationName' => $name,
'junctionProperty' => $this->_junctionProperty,
'junctionAssoc' => $this->target()->association($name),
'junctionAssoc' => $this->target()->association($name),
'junctionConditions' => $this->junctionConditions(),
'finder' => function () {
$query = $this->find();
return $this->_appendJunctionJoin($query, []);
return $this->_appendJunctionJoin($this->find(), []);
}
]);

Expand Down
3 changes: 2 additions & 1 deletion src/ORM/Association/HasMany.php
Expand Up @@ -588,7 +588,8 @@ protected function _options(array $opts)
*
* @return callable
*/
public function eagerLoader(array $options) {
public function eagerLoader(array $options)
{
$loader = new SelectLoader([
'alias' => $this->alias(),
'sourceAlias' => $this->source()->alias(),
Expand Down
3 changes: 2 additions & 1 deletion src/ORM/Association/HasOne.php
Expand Up @@ -133,7 +133,8 @@ public function saveAssociated(EntityInterface $entity, array $options = [])
*
* @return callable
*/
public function eagerLoader(array $options) {
public function eagerLoader(array $options)
{
$loader = new SelectLoader([
'alias' => $this->alias(),
'sourceAlias' => $this->source()->alias(),
Expand Down
5 changes: 3 additions & 2 deletions src/ORM/Association/Loader/SelectLoader.php
Expand Up @@ -17,8 +17,8 @@
use Cake\Database\Expression\IdentifierExpression;
use Cake\Database\Expression\TupleComparison;
use Cake\Database\ValueBinder;
use InvalidArgumentException;
use Cake\ORM\Association;
use InvalidArgumentException;
use RuntimeException;

/**
Expand Down Expand Up @@ -94,6 +94,7 @@ class SelectLoader
* Copies the options array to properties in this class. The keys in the array correspond
* to properties in this class.
*
* @param array $options Properties to be copied to this class
*/
public function __construct(array $options)
{
Expand Down Expand Up @@ -245,7 +246,7 @@ protected function _assertFieldsPresent($fetchQuery, $key)
* @param \Cake\ORM\Query $subquery The Subquery to use for filtering
* @return \Cake\ORM\Query
*/
public function _addFilteringJoin($query, $key, $subquery)
protected function _addFilteringJoin($query, $key, $subquery)
{
$filter = [];
$aliasedTable = $this->sourceAlias;
Expand Down
5 changes: 3 additions & 2 deletions src/ORM/Association/Loader/SelectWithPivotLoader.php
Expand Up @@ -55,9 +55,10 @@ class SelectWithPivotLoader extends SelectLoader
* {@inheritDoc}
*
*/
public function __construct(array $options) {
public function __construct(array $options)
{
parent::__construct($options);
$this->junctionAssociationName = $options['junctionAssociationName'];
$this->junctionAssociationName = $options['junctionAssociationName'];
$this->junctionProperty = $options['junctionProperty'];
$this->junctionAssoc = $options['junctionAssoc'];
$this->junctionConditions = $options['junctionConditions'];
Expand Down

0 comments on commit abd13e5

Please sign in to comment.