Add an option on extractTask to avoid the display of marker errors

cakephp · Aug 15, 2018 · b754ce7 · b754ce7
1 parent 6e96b4e
commit b754ce7
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/Shell/Task/ExtractTask.php b/src/Shell/Task/ExtractTask.php
@@ -104,6 +104,12 @@ class ExtractTask extends Shell
      */
     protected $_extractCore = false;
 
+    /**
+     * Does not display marker error
+     * @var bool
+     */
+    protected $markerError = true;
+
     /**
      * No welcome message.
      *
@@ -232,6 +238,8 @@ public function main()
             $this->_merge = strtolower($response) === 'y';
         }
 
+        $this->markerError = !$this->param('no-marker-error');
+
         if (empty($this->_files)) {
             $this->_searchFiles();
         }
@@ -352,6 +360,10 @@ public function getOptionParser()
             'boolean' => true,
             'default' => false,
             'help' => 'Do not write file locations for each extracted message.',
+        ])->addOption('no-marker-error', [
+            'boolean' => true,
+            'default' => false,
+            'help' => 'Do not display marker error.',
         ]);
 
         return $parser;
@@ -674,6 +686,10 @@ protected function _formatString($string)
      */
     protected function _markerError($file, $line, $marker, $count)
     {
+        if (!$this->markerError) {
+            return;
+        }
+
         $this->err(sprintf("Invalid marker content in %s:%s\n* %s(", $file, $line, $marker));
         $count += 2;
         $tokenCount = count($this->_tokens);

diff --git a/tests/test_app/TestApp/Template/Pages/extract.ctp b/tests/test_app/TestApp/Template/Pages/extract.ctp
@@ -18,6 +18,9 @@ echo __('You have %d new message.');
 echo __('double "quoted"');
 echo __("single 'quoted'");
 
+// Contains no string like a variable or a function or ...
+echo __($count);
+
 // Multiline
 __('Hot features!'
     . "\n - No Configuration:"