Reducing the amout of calls to StringTemplate in FormHelper

cakephp · Jun 16, 2014 · b77c837 · b77c837
1 parent 2118906
commit b77c837
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/View/Helper/FormHelper.php b/src/View/Helper/FormHelper.php
@@ -892,7 +892,11 @@ public function input($fieldName, array $options = []) {
 		$options += ['id' => $this->_domId($fieldName)];
 
 		$originalTemplates = $this->templates();
-		$this->templates($options['templates']);
+		$newTemplates = $options['templates'];
+
+		if ($newTemplates) {
+			$this->templates($options['templates']);
+		}
 		unset($options['templates']);
 
 		$error = null;
@@ -930,7 +934,10 @@ public function input($fieldName, array $options = []) {
 			'type' => $options['type'],
 		]);
 
-		$this->templates($originalTemplates);
+		if ($newTemplates) {
+			$this->templates($originalTemplates);
+		}
+
 		return $result;
 	}