Log query execution time and rows (#8077)

cakephp · Jan 21, 2016 · ba917d3 · ba917d3
1 parent 16726e6
commit ba917d3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/Database/Log/LoggedQuery.php b/src/Database/Log/LoggedQuery.php
@@ -65,6 +65,6 @@ class LoggedQuery
      */
     public function __toString()
     {
-        return $this->query;
+        return "duration={$this->took} rows={$this->numRows} {$this->query}";
     }
 }
diff --git a/tests/TestCase/Database/Log/LoggedQueryTest.php b/tests/TestCase/Database/Log/LoggedQueryTest.php
@@ -33,6 +33,6 @@ public function testStringConversion()
     {
         $logged = new LoggedQuery;
         $logged->query = 'SELECT foo FROM bar';
-        $this->assertEquals('SELECT foo FROM bar', (string)$logged);
+        $this->assertEquals('duration=0 rows=0 SELECT foo FROM bar', (string)$logged);
     }
 }
diff --git a/tests/TestCase/Database/Log/QueryLoggerTest.php b/tests/TestCase/Database/Log/QueryLoggerTest.php
@@ -62,7 +62,7 @@ public function testStringInterpolation()
 
         $logger->expects($this->once())->method('_log')->with($query);
         $logger->log($query);
-        $expected = "SELECT a FROM b where a = 'string' AND b = 3 AND c = NULL AND d = 1 AND e = 0 AND f = 0";
+        $expected = "duration=0 rows=0 SELECT a FROM b where a = 'string' AND b = 3 AND c = NULL AND d = 1 AND e = 0 AND f = 0";
         $this->assertEquals($expected, (string)$query);
     }
 
@@ -80,7 +80,7 @@ public function testStringInterpolation2()
 
         $logger->expects($this->once())->method('_log')->with($query);
         $logger->log($query);
-        $expected = "SELECT a FROM b where a = 'string' AND b = '3' AND c = NULL AND d = 1 AND e = 0 AND f = 0";
+        $expected = "duration=0 rows=0 SELECT a FROM b where a = 'string' AND b = '3' AND c = NULL AND d = 1 AND e = 0 AND f = 0";
         $this->assertEquals($expected, (string)$query);
     }
 
@@ -98,7 +98,7 @@ public function testStringInterpolation3()
 
         $logger->expects($this->once())->method('_log')->with($query);
         $logger->log($query);
-        $expected = "SELECT a FROM b where a = 'string' AND b = 'string' AND c = 3 AND d = 3";
+        $expected = "duration=0 rows=0 SELECT a FROM b where a = 'string' AND b = 'string' AND c = 3 AND d = 3";
         $this->assertEquals($expected, (string)$query);
     }
 
@@ -116,7 +116,7 @@ public function testStringInterpolationNamed()
 
         $logger->expects($this->once())->method('_log')->with($query);
         $logger->log($query);
-        $expected = "SELECT a FROM b where a = 'string' AND b = 'test' AND c = 5 AND d = 3";
+        $expected = "duration=0 rows=0 SELECT a FROM b where a = 'string' AND b = 'test' AND c = 5 AND d = 3";
         $this->assertEquals($expected, (string)$query);
     }