adds file close

stick it to stickler
cakephp · Jun 28, 2016 · bb79e5a · bb79e5a
1 parent 738726a
commit bb79e5a
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/src/Console/Shell.php b/src/Console/Shell.php
@@ -806,14 +806,19 @@ public function createFile($path, $contents)
         }
 
         $File = new File($path, true);
-        if ($File->exists() && $File->writable()) {
-            $File->write($contents);
-            $this->_io->out(sprintf('<success>Wrote</success> `%s`', $path));
-            return true;
-        }
 
-        $this->_io->err(sprintf('<error>Could not write to `%s`</error>.', $path), 2);
-        return false;
+        try {
+            if ($File->exists() && $File->writable()) {
+                $File->write($contents);
+                $this->_io->out(sprintf('<success>Wrote</success> `%s`', $path));
+                return true;
+            }
+
+            $this->_io->err(sprintf('<error>Could not write to `%s`</error>.', $path), 2);
+            return false;
+        } finally {
+            $File->close();
+        }
     }
 
     /**