Throw an exception if attempting to use authentication without SASL s…

…upport installed
cakephp · Aug 27, 2013 · bdd00c2 · bdd00c2
1 parent f093a31
commit bdd00c2
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/lib/Cake/Cache/Engine/MemcachedEngine.php b/lib/Cake/Cache/Engine/MemcachedEngine.php
@@ -96,6 +96,11 @@ public function init($settings = array()) {
 				}
 
 				if ($this->settings['login'] !== null && $this->settings['password'] !== null) {
+					if (!method_exists($this->_Memcached, 'setSaslAuthData')) {
+						throw new CacheException(
+							__d('cake_dev', 'Memcached extension is not build with SASL support')
+						);
+					}
 					$this->_Memcached->setSaslAuthData($this->settings['login'], $this->settings['password']);
 				}
 			}

diff --git a/lib/Cake/Test/Case/Cache/Engine/MemcachedEngineTest.php b/lib/Cake/Test/Case/Cache/Engine/MemcachedEngineTest.php
@@ -133,6 +133,33 @@ public function testCompressionSetting() {
 		$this->assertTrue($MemcachedCompressed->getMemcached()->getOption(Memcached::OPT_COMPRESSION));
 	}
 
+/**
+ * test using authentication without memcached installed with SASL support
+ * throw an exception
+ *
+ * @return void
+ */
+	public function testSaslAuthException() {
+		$Memcached = new TestMemcachedEngine();
+		$settings = array(
+			'engine' => 'Memcached',
+			'servers' => array('127.0.0.1:11211'),
+			'persistent' => false,
+			'login' => 'test',
+			'password' => 'password'
+		);
+
+		$this->skipIf(
+			method_exists($Memcached->getMemcached(), 'setSaslAuthData'),
+			'Memcached extension is installed with SASL support'
+		);
+
+		$this->setExpectedException(
+        	'CacheException', 'Memcached extension is not build with SASL support'
+        );
+		$Memcached->init($settings);
+	}
+
 /**
  * testSettings method
  *