should => must

cakephp · Sep 25, 2017 · be5cb6f · be5cb6f
1 parent 5c46f8b
commit be5cb6f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Database/Query.php b/src/Database/Query.php
@@ -1253,7 +1253,7 @@ public function orHaving($conditions, $types = [])
      * in the record set you want as results. If empty the limit will default to
      * the existing limit clause, and if that too is empty, then `25` will be used.
      *
-     * Pages should start at 1.
+     * Pages must start at 1.
      *
      * @param int $num The page number you want.
      * @param int|null $limit The number of rows you want in the page. If null
@@ -1264,7 +1264,7 @@ public function orHaving($conditions, $types = [])
     public function page($num, $limit = null)
     {
         if ($num < 1) {
-            throw new InvalidArgumentException('Pages should start at 1.');
+            throw new InvalidArgumentException('Pages must start at 1.');
         }
         if ($limit !== null) {
             $this->limit($limit);

diff --git a/src/Datasource/QueryInterface.php b/src/Datasource/QueryInterface.php
@@ -234,7 +234,7 @@ public function order($fields, $overwrite = false);
      * in the record set you want as results. If empty the limit will default to
      * the existing limit clause, and if that too is empty, then `25` will be used.
      *
-     * Pages should start at 1.
+     * Pages must start at 1.
      *
      * @param int $num The page number you want.
      * @param int|null $limit The number of rows you want in the page. If null

diff --git a/tests/TestCase/Database/QueryTest.php b/tests/TestCase/Database/QueryTest.php
@@ -2210,7 +2210,7 @@ public function testSelectOffset()
      * Test Pages number.
      *
      * @expectedException \InvalidArgumentException
-     * @expectedExceptionMessage Pages should start at 1.
+     * @expectedExceptionMessage Pages must start at 1.
      * @return void
      */
     public function testPageShouldStartAtOne()