From be5cb6fb32fd8e17f2318ba2609339ebf02aef0f Mon Sep 17 00:00:00 2001 From: saeid Date: Mon, 25 Sep 2017 23:18:01 +0330 Subject: [PATCH] should => must --- src/Database/Query.php | 4 ++-- src/Datasource/QueryInterface.php | 2 +- tests/TestCase/Database/QueryTest.php | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Database/Query.php b/src/Database/Query.php index 98d9219c08e..4a60d2fefe4 100644 --- a/src/Database/Query.php +++ b/src/Database/Query.php @@ -1253,7 +1253,7 @@ public function orHaving($conditions, $types = []) * in the record set you want as results. If empty the limit will default to * the existing limit clause, and if that too is empty, then `25` will be used. * - * Pages should start at 1. + * Pages must start at 1. * * @param int $num The page number you want. * @param int|null $limit The number of rows you want in the page. If null @@ -1264,7 +1264,7 @@ public function orHaving($conditions, $types = []) public function page($num, $limit = null) { if ($num < 1) { - throw new InvalidArgumentException('Pages should start at 1.'); + throw new InvalidArgumentException('Pages must start at 1.'); } if ($limit !== null) { $this->limit($limit); diff --git a/src/Datasource/QueryInterface.php b/src/Datasource/QueryInterface.php index 5589b3d0081..375d70986fb 100644 --- a/src/Datasource/QueryInterface.php +++ b/src/Datasource/QueryInterface.php @@ -234,7 +234,7 @@ public function order($fields, $overwrite = false); * in the record set you want as results. If empty the limit will default to * the existing limit clause, and if that too is empty, then `25` will be used. * - * Pages should start at 1. + * Pages must start at 1. * * @param int $num The page number you want. * @param int|null $limit The number of rows you want in the page. If null diff --git a/tests/TestCase/Database/QueryTest.php b/tests/TestCase/Database/QueryTest.php index b2d39899f41..32377d4aab2 100644 --- a/tests/TestCase/Database/QueryTest.php +++ b/tests/TestCase/Database/QueryTest.php @@ -2210,7 +2210,7 @@ public function testSelectOffset() * Test Pages number. * * @expectedException \InvalidArgumentException - * @expectedExceptionMessage Pages should start at 1. + * @expectedExceptionMessage Pages must start at 1. * @return void */ public function testPageShouldStartAtOne()