Fixing issue in DboSource::_matchRecords() where unqualified conditio…

…ns would result in 1=1 conditions. Fixing incorrect test case. Fixes #930
cakephp · Sep 16, 2010 · d12d2d7 · d12d2d7
1 parent 9bf6fbf
commit d12d2d7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/cake/libs/model/datasources/dbo_source.php b/cake/libs/model/datasources/dbo_source.php
@@ -1487,8 +1487,10 @@ function _matchRecords(&$model, $conditions = null) {
 					$noJoin = false;
 					break;
 				}
-				$conditions[$field] = $value;
-				unset($conditions[$originalField]);
+				if ($field !== $originalField) {
+					$conditions[$field] = $value;
+					unset($conditions[$originalField]);
+				}
 			}
 			if ($noJoin === true) {
 				return $this->conditions($conditions);

diff --git a/cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php b/cake/tests/cases/libs/model/datasources/dbo/dbo_postgres.test.php
@@ -662,13 +662,13 @@ function testAlterIndexes() {
 	function testUpdateAllWithNonQualifiedConditions() {
 		$this->loadFixtures('Article');
 		$Article =& new Article();
-		$result = $Article->updateAll(array('title' => "'Awesome'"), array('published' => 'Y'));
+		$result = $Article->updateAll(array('title' => "'Awesome'"), array('title' => 'Third Article'));
 		$this->assertTrue($result);
 
 		$result = $Article->find('count', array(
 			'conditions' => array('Article.title' => 'Awesome')
 		));
-		$this->assertEqual($result, 3, 'Article count is wrong or fixture has changed.');
+		$this->assertEqual($result, 1, 'Article count is wrong or fixture has changed.');
 	}
 }
-?>
+?>