Skip to content

Commit

Permalink
Correctly passing ellipsis options to all internal method calls insie
Browse files Browse the repository at this point in the history
PaginatorHelper::numbers(), under some combinations of modulus/limit
it would not get passed even though there are pages in between to show
  • Loading branch information
lorenzo committed Jul 11, 2012
1 parent 39715bc commit db24755
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/Cake/View/Helper/PaginatorHelper.php
Expand Up @@ -701,7 +701,7 @@ public function numbers($options = array()) {
if ($offset < $start - 1) {
$out .= $this->first($offset, compact('tag', 'separator', 'ellipsis', 'class'));
} else {
$out .= $this->first($offset, compact('tag', 'separator', 'class') + array('after' => $separator));
$out .= $this->first($offset, compact('tag', 'separator', 'class', 'ellipsis') + array('after' => $separator));
}
}

Expand Down Expand Up @@ -735,7 +735,7 @@ public function numbers($options = array()) {
if ($offset <= $last && $params['pageCount'] - $end > $offset) {
$out .= $this->last($offset, compact('tag', 'separator', 'ellipsis', 'class'));
} else {
$out .= $this->last($offset, compact('tag', 'separator', 'class') + array('before' => $separator));
$out .= $this->last($offset, compact('tag', 'separator', 'class', 'ellipsis') + array('before' => $separator));
}
}

Expand Down

0 comments on commit db24755

Please sign in to comment.