Fix phpstan reported error in Xml class.

cakephp · Aug 21, 2017 · dcf59f7 · dcf59f7
1 parent b387608
commit dcf59f7
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/Utility/Xml.php b/src/Utility/Xml.php
@@ -328,8 +328,20 @@ protected static function _fromArray($dom, $node, &$data, $format)
      */
     protected static function _createChild($data)
     {
-        $value = $dom = $key = $format = $node = null;
-        extract($data);
+        $data += [
+            'dom' => null,
+            'node' => null,
+            'key' => null,
+            'value' => null,
+            'format' => null,
+        ];
+
+        $value = $data['value'];
+        $dom = $data['dom'];
+        $key = $data['key'];
+        $format = $data['format'];
+        $node = $data['node'];
+
         $childNS = $childValue = null;
         if (is_object($value) && method_exists($value, 'toArray') && is_callable([$value, 'toArray'])) {
             $value = call_user_func([$value, 'toArray']);