Updating coverage report and tests to include hiding javascript.

cakephp · May 10, 2010 · e8e2235 · e8e2235
1 parent f084a82
commit e8e2235
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 5 deletions.
diff --git a/cake/tests/cases/libs/html_coverage_report.test.php b/cake/tests/cases/libs/html_coverage_report.test.php
@@ -173,8 +173,8 @@ function testGenerateDiff() {
 			)
 		);
 		$result = $this->Coverage->generateDiff('myfile.php', $file, $coverage);
-		$this->assertRegExp('/<h2>myfile\.php Code coverage\: \d+\.?\d*\%<\/h2>/', $result);
-		$this->assertRegExp('/<div class="code-coverage-results">/', $result);
+		$this->assertRegExp('/myfile\.php Code coverage\: \d+\.?\d*\%/', $result);
+		$this->assertRegExp('/<div class="code-coverage-results" id\="coverage\-myfile\.php"/', $result);
 		$this->assertRegExp('/<pre>/', $result);
 		foreach ($file as $i => $line) {
 			$this->assertTrue(strpos($line, $result) !== 0, 'Content is missing ' . $i);

diff --git a/cake/tests/lib/coverage/html_coverage_report.php b/cake/tests/lib/coverage/html_coverage_report.php
@@ -84,7 +84,7 @@ public function report() {
 		if (empty($coverageData)) {
 			return '<h3>No files to generate coverage for</h3>';
 		}
-		$output = '';
+		$output = $this->coverageScript();
 		foreach ($coverageData as $file => $coverageData) {
 			$fileData = file($file);
 			$output .= $this->generateDiff($file, $fileData, $coverageData);
@@ -197,6 +197,21 @@ protected function _paintLine($line, $linenumber, $class) {
 		);
 	}
 
+/**
+ * generate some javascript for the coverage report.
+ *
+ * @return void
+ */
+	public function coverageScript() {
+		return <<<HTML
+		<script type="text/javascript">
+		function coverage_show_hide(selector) {
+			var element = document.getElementById(selector);
+			element.style.display = (element.style.display == 'none') ? '' : 'none';
+		}
+		</script>
+HTML;
+	}
 
 /**
  * Generate an HTML snippet for coverage headers
@@ -206,8 +221,12 @@ protected function _paintLine($line, $linenumber, $class) {
 	public function coverageHeader($filename, $percent) {
 		$filename = basename($filename);
 		return <<<HTML
-	<h2>$filename Code coverage: $percent%</h2>
-	<div class="code-coverage-results">
+	<h4>
+		<a href="#coverage-$filename" onclick="coverage_show_hide('coverage-$filename');">
+			$filename Code coverage: $percent%
+		</a>
+	</h4>
+	<div class="code-coverage-results" id="coverage-$filename" style="display:none;">
 	<pre>
 HTML;
 	}