Skip Memcached and Redis tests when servers are not running.

When the extensions are present but memcached or redis are not running, tests should be skipped. Refs #5993
cakephp · Mar 3, 2015 · f53cdbf · f53cdbf
1 parent acdaffc
commit f53cdbf
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/src/Cache/Engine/MemcachedEngine.php b/src/Cache/Engine/MemcachedEngine.php
@@ -115,7 +115,7 @@ public function init(array $config = [])
         }
 
         parent::init($config);
-        
+
         if (!empty($config['host'])) {
             if (empty($config['port'])) {
                 $config['servers'] = [$config['host']];

diff --git a/tests/TestCase/Cache/Engine/MemcachedEngineTest.php b/tests/TestCase/Cache/Engine/MemcachedEngineTest.php
@@ -66,6 +66,10 @@ public function setUp()
         parent::setUp();
         $this->skipIf(!class_exists('Memcached'), 'Memcached is not installed or configured properly.');
 
+        $socket = @fsockopen('127.0.0.1', 11211, $errno, $errstr, 1);
+        $this->skipIf(!$socket, 'Memcached is not running.');
+        fclose($socket);
+
         $this->_configCache();
     }
 
@@ -831,8 +835,6 @@ public function testZeroDuration()
      */
     public function testLongDurationEqualToZero()
     {
-        $this->markTestSkipped('Cannot run as Memcached cannot be reflected');
-
         $memcached = new TestMemcachedEngine();
         $memcached->init(['prefix' => 'Foo_', 'compress' => false, 'duration' => 50 * DAY]);
 

diff --git a/tests/TestCase/Cache/Engine/RedisEngineTest.php b/tests/TestCase/Cache/Engine/RedisEngineTest.php
@@ -36,7 +36,11 @@ class RedisEngineTest extends TestCase
     public function setUp()
     {
         parent::setUp();
-        $this->skipIf(!class_exists('Redis'), 'Redis is not installed or configured properly.');
+        $this->skipIf(!class_exists('Redis'), 'Redis extension is not installed or configured properly.');
+
+        $socket = @fsockopen('127.0.0.1', 6379, $errno, $errstr, 1);
+        $this->skipIf(!$socket, 'Redis is not running.');
+        fclose($socket);
 
         Cache::enable();
         $this->_configCache();